From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3mZ4-0006i3-4A for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:09:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3mYz-0000P0-Vp for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:09:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3mYz-0000Ot-Om for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:09:53 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 49F2D19CBC8 for ; Tue, 1 Dec 2015 15:09:53 +0000 (UTC) References: <1448883140-20249-1-git-send-email-peterx@redhat.com> <1448883140-20249-3-git-send-email-peterx@redhat.com> <565CC816.8020507@redhat.com> <20151201021833.GD21032@pxdev.xzpeter.org> From: Paolo Bonzini Message-ID: <565DB83C.30905@redhat.com> Date: Tue, 1 Dec 2015 16:09:48 +0100 MIME-Version: 1.0 In-Reply-To: <20151201021833.GD21032@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu , Eric Blake Cc: drjones@redhat.com, famz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, lersek@redhat.com On 01/12/2015 03:18, Peter Xu wrote: > I think (2) is better in term of lines of codes (and also > clear). However I may need to keep the QMP interface (to keep the > has_detach parameter in qmp_dump_guest_memory), so I'd like to > choose (1). It's also okay to also pass has_detach =3D true to qmp_dump_guest_memory. Paolo