From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3mqy-0006Aq-TQ for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:28:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3mqt-00064y-DR for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:28:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3mqt-00064r-87 for qemu-devel@nongnu.org; Tue, 01 Dec 2015 10:28:23 -0500 References: <1448904887-4977-1-git-send-email-ehabkost@redhat.com> <565DB838.5010005@redhat.com> <20151201152535.GK23717@thinpad.lan.raisama.net> From: Paolo Bonzini Message-ID: <565DBC93.8000001@redhat.com> Date: Tue, 1 Dec 2015 16:28:19 +0100 MIME-Version: 1.0 In-Reply-To: <20151201152535.GK23717@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Huaitong Han , qemu-devel@nongnu.org, kvm@vger.kernel.org On 01/12/2015 16:25, Eduardo Habkost wrote: > > I think it's easier to use small guests (i.e. kvm-unit-tests) to test > > this code. > > I agree it's easier, but how likely it is to catch bugs in the > save/load code? If the code corrupts a register, we need to > trigger a save/load cycle at the exact moment the guest code is > using that register. Do we have something that helps us > repeatedly save/load CPU state while kvm-unit-tests is running? A vmware magic port read should do that. Put VMPORT_MAGIC in EAX and VMPORT_CMD_GETVERSION in ECX, then do a 32-bit in from port 0x5658. Paolo