From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3nQ7-0005vv-7h for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:04:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3nQ2-0001GF-CF for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:04:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3nQ2-0001GB-6u for qemu-devel@nongnu.org; Tue, 01 Dec 2015 11:04:42 -0500 References: <1448882964-22433-1-git-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <565DC516.9070708@redhat.com> Date: Tue, 1 Dec 2015 17:04:38 +0100 MIME-Version: 1.0 In-Reply-To: <1448882964-22433-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5] main-loop: suppress warnings under qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell On 30/11/2015 12:30, Michael S. Tsirkin wrote: > commit 01c22f2cdd4fcf02276ea10f48253850a5fd7259 ("main-loop: Suppress > "I/O thread spun" warnings for qtest") doesn't actually disable the > warning for everyone since some tests don't run under the qtest > accelerator. > > Check qtest_driver instead. > > Cc: Peter Maydell > Signed-off-by: Michael S. Tsirkin > --- > main-loop.c | 2 +- > stubs/qtest.c | 5 +++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/main-loop.c b/main-loop.c > index df28670..5877615 100644 > --- a/main-loop.c > +++ b/main-loop.c > @@ -230,7 +230,7 @@ static int os_host_main_loop_wait(int64_t timeout) > if (!timeout && (spin_counter > MAX_MAIN_LOOP_SPIN)) { > static bool notified; > > - if (!notified && !qtest_enabled()) { > + if (!notified && !qtest_driver()) { > fprintf(stderr, > "main-loop: WARNING: I/O thread spun for %d iterations\n", > MAX_MAIN_LOOP_SPIN); > diff --git a/stubs/qtest.c b/stubs/qtest.c > index dc17594..4dfde61 100644 > --- a/stubs/qtest.c > +++ b/stubs/qtest.c > @@ -12,3 +12,8 @@ > > /* Needed for qtest_allowed() */ > bool qtest_allowed; > + > +bool qtest_driver(void) > +{ > + return false; > +} > Queued for 2.5, thanks. Will send pull request tomorrow morning. Paolo