From: Richard Henderson <rth@twiddle.net>
To: Eduardo Habkost <ehabkost@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Huaitong Han <huaitong.han@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area
Date: Tue, 1 Dec 2015 10:42:57 -0800 [thread overview]
Message-ID: <565DEA31.4090707@twiddle.net> (raw)
In-Reply-To: <20151201183441.GO23717@thinpad.lan.raisama.net>
On 12/01/2015 10:34 AM, Eduardo Habkost wrote:
> BTW, if we are going to implement xsave in TCG, the
> X86CPU<->xsave translation logic in kvm_{get,put}_xsave() could
> be moved to generic code and reused by TCG instead of being
> reimplemented.
That's not trivial.
In particular, stq_p isn't what the tcg helper needs to use, but rather
cpu_stq_data_ra. Given the differing parameters, we'd have to resort to some
sort of macro-ization. It's probably easiest to simply keep the two
implementations separate.
r~
next prev parent reply other threads:[~2015-12-01 18:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 19:56 [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] [for-2.6 PATCH 1/3] target-i386: Define structs for layout of xsave area Eduardo Habkost
2015-11-30 11:18 ` Paolo Bonzini
2015-11-30 14:48 ` Eduardo Habkost
2015-12-01 17:09 ` Richard Henderson
2015-12-01 17:15 ` Eduardo Habkost
2015-12-01 17:20 ` Richard Henderson
2015-12-01 17:27 ` Paolo Bonzini
2015-12-01 18:34 ` Eduardo Habkost
2015-12-01 18:42 ` Richard Henderson [this message]
2015-11-28 19:56 ` [Qemu-devel] [for-2.6 PATCH 2/3] target-i386: Use xsave structs for ext_save_area Eduardo Habkost
2015-11-28 19:56 ` [Qemu-devel] [for-2.6 PATCH 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load Eduardo Habkost
2015-11-30 11:21 ` [Qemu-devel] [for-2.6 PATCH 0/3] target-i386: Use C struct for xsave area layout, offsets & sizes Paolo Bonzini
2015-11-30 14:14 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565DEA31.4090707@twiddle.net \
--to=rth@twiddle.net \
--cc=ehabkost@redhat.com \
--cc=huaitong.han@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).