From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a41IA-0003O3-N2 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 01:53:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a41I6-0007nG-ND for qemu-devel@nongnu.org; Wed, 02 Dec 2015 01:53:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40378) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a41I6-0007nA-Hc for qemu-devel@nongnu.org; Wed, 02 Dec 2015 01:53:26 -0500 References: <1448976641-32617-1-git-send-email-victork@redhat.com> From: Jason Wang Message-ID: <565E9562.7060408@redhat.com> Date: Wed, 2 Dec 2015 14:53:22 +0800 MIME-Version: 1.0 In-Reply-To: <1448976641-32617-1-git-send-email-victork@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost-user: verify that number of queues is non-zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Victor Kaplansky , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Changchun Ouyang On 12/01/2015 09:32 PM, Victor Kaplansky wrote: > Fix QEMU crash when -netdev type=vhost-user,queues=n is passed > with zero number of queues. > > Signed-off-by: Victor Kaplansky > --- > net/vhost-user.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/vhost-user.c b/net/vhost-user.c > index 5071602..b368a90 100644 > --- a/net/vhost-user.c > +++ b/net/vhost-user.c > @@ -316,6 +316,11 @@ int net_init_vhost_user(const NetClientOptions *opts, const char *name, > } > > queues = vhost_user_opts->has_queues ? vhost_user_opts->queues : 1; > + if (queues < 1) { > + error_setg(errp, > + "vhost-user number of queues must be bigger than zero"); > + return -1; > + } > > return net_vhost_user_init(peer, "vhost_user", name, chr, queues); > } Acked-by: Jason Wang