From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46206)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a46Qx-0003jb-84
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 07:22:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a46Qt-0001As-BQ
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 07:22:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a46Qt-0001Ad-6q
	for qemu-devel@nongnu.org; Wed, 02 Dec 2015 07:22:51 -0500
References: <1448900541-19939-1-git-send-email-asmetanin@virtuozzo.com>
	<1448900541-19939-2-git-send-email-asmetanin@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <565EE292.7010004@redhat.com>
Date: Wed, 2 Dec 2015 13:22:42 +0100
MIME-Version: 1.0
In-Reply-To: <1448900541-19939-2-git-send-email-asmetanin@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum
	hv_message_type by u32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrey Smetanin <asmetanin@virtuozzo.com>, kvm@vger.kernel.org
Cc: Gleb Natapov <gleb@kernel.org>, Haiyang Zhang <haiyangz@microsoft.com>, qemu-devel@nongnu.org, Roman Kagan <rkagan@virtuozzo.com>, "Denis V. Lunev" <den@openvz.org>, Vitaly Kuznetsov <vkuznets@redhat.com>, "K. Y. Srinivasan" <kys@microsoft.com>



On 30/11/2015 17:22, Andrey Smetanin wrote:
> enum hv_message_type inside struct hv_message, hv_post_message
> is not size portable. Replace enum by u32.

It's only non-portable inside structs.  Okay to apply just these:

@@ -172,7 +174,7 @@ union hv_message_flags {

 /* Define synthetic interrupt controller message header. */
 struct hv_message_header {
-	u32 message_type;
+	enum hv_message_type message_type;
 	u8 payload_size;
 	union hv_message_flags message_flags;
 	u8 reserved[2];
@@ -345,7 +347,7 @@ enum hv_call_code {
 struct hv_input_post_message {
 	union hv_connection_id connectionid;
 	u32 reserved;
-	u32 message_type;
+	enum hv_message_type message_type;
 	u32 payload_size;
 	u64 payload[HV_MESSAGE_PAYLOAD_QWORD_COUNT];
 };

?

Paolo