From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a47fT-0005cO-Dq for qemu-devel@nongnu.org; Wed, 02 Dec 2015 08:42:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a47fO-0001cF-P3 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 08:41:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a47fO-0001cA-Jf for qemu-devel@nongnu.org; Wed, 02 Dec 2015 08:41:54 -0500 References: <1449033659-25497-1-git-send-email-eblake@redhat.com> <1449033659-25497-14-git-send-email-eblake@redhat.com> <87lh9dukyw.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <565EF521.5030307@redhat.com> Date: Wed, 2 Dec 2015 06:41:53 -0700 MIME-Version: 1.0 In-Reply-To: <87lh9dukyw.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D8IEdm77n3HemjsRojt5jS0d3J2rUqxcs" Subject: Re: [Qemu-devel] [PATCH v14 13/15] qapi: Enforce (or whitelist) case conventions on qapi members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D8IEdm77n3HemjsRojt5jS0d3J2rUqxcs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/2015 04:51 AM, Markus Armbruster wrote: > This is the fixup I mentioned in the v13 thread. The "Unreachable and > not implemented" hunk should probably be its own patch. In fact, that hunk... >=20 > diff --git a/scripts/qapi.py b/scripts/qapi.py > index 6d38d7c..870e476 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -1073,7 +1071,8 @@ class QAPISchemaMember(object): > return '(parameter of %s)' % owner[:-4] > else: > assert owner.endswith('-wrapper') > - return '(branch of %s)' % owner[:-8] > + # Unreachable and not implemented > + assert False > if owner.endswith('Kind'): > # See QAPISchema._make_implicit_enum_type() > return '(branch of %s)' % owner[:-4] =2E..should probably just be squashed directly into commit 8f3a05b on you= r current qapi-next branch, since it hasn't landed upstream yet. Your fixup looks sane, and eliminates the need for 12/15. So I'm fine if you'd like to make that change when updating qapi-next. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --D8IEdm77n3HemjsRojt5jS0d3J2rUqxcs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXvUhAAoJEKeha0olJ0NqjhsIAJqV9YIRbiMNO5+xRQwR1X6C g/S3z1szTP+rL8WWrXccRHyIEHMNg5ZT2Xz95LMtumGjQdtN3cb+TReQ0Mq5oslr 7oZIo4lPfGNjkBaHZjq4uGiIlPVZgiA0ehbZdjxzUOrTkXefRlvg5Wk5WWP98y1N Tp4/YV2eXJC22q28uRzEiTNAUjXDEvNjYZGhXZ8ECtNKmG9Z7u/C46EP3gS/Fb9Y f16Dt83kZSDxe1WUlT4BxGA6Lnv/2ey5lzhpUEC4gW99w9/Yoxt8DdIZEeowt6H8 9gWp/4MfN7zY90Zrv/ZqUYPxWhlSP/xwtZ4P8G9oj1/gPc8kk67gFVgKwUBdcDw= =tJxI -----END PGP SIGNATURE----- --D8IEdm77n3HemjsRojt5jS0d3J2rUqxcs--