From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a488g-0004ao-IW for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:12:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a488c-00046T-G2 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:12:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a488c-00046L-Ag for qemu-devel@nongnu.org; Wed, 02 Dec 2015 09:12:06 -0500 References: <1449033659-25497-1-git-send-email-eblake@redhat.com> <1449033659-25497-14-git-send-email-eblake@redhat.com> <87lh9dukyw.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <565EFC2C.8020505@redhat.com> Date: Wed, 2 Dec 2015 07:11:56 -0700 MIME-Version: 1.0 In-Reply-To: <87lh9dukyw.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Pe3jTa1Crbu6hOkTSVpunkvMHHqgVAjxK" Subject: Re: [Qemu-devel] [PATCH v14 13/15] qapi: Enforce (or whitelist) case conventions on qapi members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Pe3jTa1Crbu6hOkTSVpunkvMHHqgVAjxK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/2015 04:51 AM, Markus Armbruster wrote: > This is the fixup I mentioned in the v13 thread. The "Unreachable and > not implemented" hunk should probably be its own patch. >=20 > +++ b/tests/qapi-schema/args-member-case.err > @@ -1 +1 @@ > -tests/qapi-schema/args-member-case.json:3: Member 'Arg' of 'Foo' shoul= d use lowercase > +tests/qapi-schema/args-member-case.json:3: 'Arg' (parameter of Foo) sh= ould not use uppercase Oh, and I forgot to use the name 'no-way-this-will-get-whitelisted' (or NoWayThisWillGetWhitelisted) as suggested in v13, if you want to also change naming. > diff --git a/tests/qapi-schema/enum-member-case.err b/tests/qapi-schema= /enum-member-case.err > index e50b12a..a1d67c6 100644 > --- a/tests/qapi-schema/enum-member-case.err > +++ b/tests/qapi-schema/enum-member-case.err > @@ -1 +1 @@ > -tests/qapi-schema/enum-member-case.json:3: Member 'Value' of 'Foo' sho= uld use lowercase > +tests/qapi-schema/enum-member-case.json:3: 'Value' (member of Foo) sho= uld not use uppercase > diff --git a/tests/qapi-schema/union-branch-case.err b/tests/qapi-schem= a/union-branch-case.err > index 6c6b740..0b4c1b5 100644 > --- a/tests/qapi-schema/union-branch-case.err > +++ b/tests/qapi-schema/union-branch-case.err > @@ -1 +1 @@ > -tests/qapi-schema/union-branch-case.json:3: Member 'Branch' of 'Foo' s= hould use lowercase > +tests/qapi-schema/union-branch-case.json:3: 'Branch' (branch of Foo) s= hould not use uppercase >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Pe3jTa1Crbu6hOkTSVpunkvMHHqgVAjxK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXvwsAAoJEKeha0olJ0NqCaoH/1DrhAFKnrJK+/CCBXhLiklb Db6FcRE9evtyP4SJo053JvyWReWETln0Hrw6blLFo1IZWYzGSHZdpEuXx7E/r2U+ XkB1D+3XWDkmVIv5WHrzTNA6GU/mDwK1ht4SXMXCHmMrdOIWjY+T33kU5KDdUOAe HJEVaRJsdT54EE2LnIF2hIizzXfgTQf1TbhQpnG6uYz7A+y9DZ9ngUwM3LZgohbW Tj5qQIevpOa07WtIObumYofgZAL7D+gmsBz9hEt1ryOplId6bZUhoEOGTED76GtX TxwBB8/TIWkFk43bh2404S6u95G58b2kGG/ryxjSQKbT8uMQ2MameQqkRQVFrvk= =Gc5m -----END PGP SIGNATURE----- --Pe3jTa1Crbu6hOkTSVpunkvMHHqgVAjxK--