* Re: [Qemu-devel] [PATCH] vhost: drop dead code
2015-12-02 11:50 [Qemu-devel] [PATCH] vhost: drop dead code Michael S. Tsirkin
@ 2015-12-02 13:12 ` Yuanhan Liu
2015-12-02 15:56 ` Eric Blake
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Yuanhan Liu @ 2015-12-02 13:12 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?=, Jason Wang, Michael Tokarev,
qemu-devel
On Wed, Dec 02, 2015 at 01:50:35PM +0200, Michael S. Tsirkin wrote:
> We dropped the implementation of vhost_dev_query,
> drop it from the header file as well.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
--yliu
> ---
> include/hw/virtio/vhost.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
> index 7437fd4..b60d758 100644
> --- a/include/hw/virtio/vhost.h
> +++ b/include/hw/virtio/vhost.h
> @@ -66,7 +66,6 @@ struct vhost_dev {
> int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
> VhostBackendType backend_type);
> void vhost_dev_cleanup(struct vhost_dev *hdev);
> -bool vhost_dev_query(struct vhost_dev *hdev, VirtIODevice *vdev);
> int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
> void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev);
> int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
> --
> MST
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vhost: drop dead code
2015-12-02 11:50 [Qemu-devel] [PATCH] vhost: drop dead code Michael S. Tsirkin
2015-12-02 13:12 ` Yuanhan Liu
@ 2015-12-02 15:56 ` Eric Blake
2015-12-04 2:09 ` Jason Wang
2015-12-04 6:11 ` Michael Tokarev
3 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2015-12-02 15:56 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Marc-André Lureau, Yuanhan Liu, Michael Tokarev, Jason Wang
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
On 12/02/2015 04:50 AM, Michael S. Tsirkin wrote:
> We dropped the implementation of vhost_dev_query,
Might be nice to add "in commit 1e7398a1".
> drop it from the header file as well.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/virtio/vhost.h | 1 -
> 1 file changed, 1 deletion(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost: drop dead code
2015-12-02 11:50 [Qemu-devel] [PATCH] vhost: drop dead code Michael S. Tsirkin
2015-12-02 13:12 ` Yuanhan Liu
2015-12-02 15:56 ` Eric Blake
@ 2015-12-04 2:09 ` Jason Wang
2015-12-04 6:11 ` Michael Tokarev
3 siblings, 0 replies; 5+ messages in thread
From: Jason Wang @ 2015-12-04 2:09 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Marc-André Lureau, Yuanhan Liu, Michael Tokarev
On 12/02/2015 07:50 PM, Michael S. Tsirkin wrote:
> We dropped the implementation of vhost_dev_query,
> drop it from the header file as well.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/virtio/vhost.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
> index 7437fd4..b60d758 100644
> --- a/include/hw/virtio/vhost.h
> +++ b/include/hw/virtio/vhost.h
> @@ -66,7 +66,6 @@ struct vhost_dev {
> int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
> VhostBackendType backend_type);
> void vhost_dev_cleanup(struct vhost_dev *hdev);
> -bool vhost_dev_query(struct vhost_dev *hdev, VirtIODevice *vdev);
> int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
> void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev);
> int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] vhost: drop dead code
2015-12-02 11:50 [Qemu-devel] [PATCH] vhost: drop dead code Michael S. Tsirkin
` (2 preceding siblings ...)
2015-12-04 2:09 ` Jason Wang
@ 2015-12-04 6:11 ` Michael Tokarev
3 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2015-12-04 6:11 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel
Cc: Marc-André Lureau, Yuanhan Liu, Jason Wang
02.12.2015 14:50, Michael S. Tsirkin wrote:
> We dropped the implementation of vhost_dev_query,
> drop it from the header file as well.
Applied to -trivial with a commit message fix suggested
by Eric. Thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread