From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a49qL-0002nS-9M for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:01:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a49qI-00074c-Hd for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:01:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a49qI-000746-DL for qemu-devel@nongnu.org; Wed, 02 Dec 2015 11:01:18 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7FA7EC0A8031 for ; Wed, 2 Dec 2015 16:01:17 +0000 (UTC) References: <1448976530-15984-1-git-send-email-peterx@redhat.com> <1448976530-15984-9-git-send-email-peterx@redhat.com> <20151202011131.GE9399@ad.usersys.redhat.com> <565F0420.10409@redhat.com> <20151202152134.GA18589@pxdev.xzpeter.org> From: Eric Blake Message-ID: <565F15CC.4020706@redhat.com> Date: Wed, 2 Dec 2015 09:01:16 -0700 MIME-Version: 1.0 In-Reply-To: <20151202152134.GA18589@pxdev.xzpeter.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vgl5staPoHucsKtgfmSAhXPqUOBrGDVQ0" Subject: Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, Fam Zheng , armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vgl5staPoHucsKtgfmSAhXPqUOBrGDVQ0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/2015 08:21 AM, Peter Xu wrote: > On Wed, Dec 02, 2015 at 07:45:52AM -0700, Eric Blake wrote: >> On 12/01/2015 06:11 PM, Fam Zheng wrote: >>> Please explicitly mention that successful dump emits DUMP_COMPLETED w= ithout >>> error, and failed dump emits DUMP_COMPLETED that has an error str. >> >> In fact, I wonder if it would also be worth having a >> 'status':'DumpStatus' field, which records the final status of the dum= p >> (either 'completed' or 'failed'), and which is always present. >=20 > Will the raw memory total size useful in any way? I am totally ok to > add this, just failed to find a way for user to use it besides > calculating finished work during dump... :( Good idea. You never know if it will be helpful, but the information is basically free to provide and doesn't seem like too much of a maintenance burden to promise to always include the total. And in the case of an error, knowing the final values of complete/total might also be useful to see how far things got before failure (for example, if it failed because of ENOSPACE, knowing how much was complete may give an idea of how much additional space should be added before retrying). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Vgl5staPoHucsKtgfmSAhXPqUOBrGDVQ0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWXxXMAAoJEKeha0olJ0NqfbQH/2ORWMxljlh2iD0ABBJjve8D xSfno8D0iFDIL6Jg0TdLUBdvXI/XwUY0+2tzEdlum+wfrQuHrGqAECVGVm3lbwVV hr/iNTfO+y0pCgJSTzMmeyk9jSfbgRBMnvq/Sqcu40NJrl49Ld+esAN/9Hb7AyUQ AKAgPJQBk3ZHrKsjzdXzwyZzyJBRsoCAbcs9darrxmo6ksWDBJiPx3cylelUOBEp iScbxKpBcuj/GWUMJy6QbKkGUqoRPTwb1K9pujpfog5QLzLHO/hxApwRDkZVOhIn g0meRrUAsP1//T8wsIurE0WLArS2pXbxQ8gZrz3uUD7/81SrvIIMvJVEyTCkf/U= =15jo -----END PGP SIGNATURE----- --Vgl5staPoHucsKtgfmSAhXPqUOBrGDVQ0--