From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50253) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4DJS-0002Q9-99 for qemu-devel@nongnu.org; Wed, 02 Dec 2015 14:43:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4DJN-0007fg-Iy for qemu-devel@nongnu.org; Wed, 02 Dec 2015 14:43:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4DJN-0007fI-BY for qemu-devel@nongnu.org; Wed, 02 Dec 2015 14:43:33 -0500 References: <1449033659-25497-1-git-send-email-eblake@redhat.com> <1449033659-25497-14-git-send-email-eblake@redhat.com> <87lh9dukyw.fsf@blackfin.pond.sub.org> <565EF521.5030307@redhat.com> <565F0C00.8050805@redhat.com> <87oae8ix9b.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <565F49DE.8060303@redhat.com> Date: Wed, 2 Dec 2015 12:43:26 -0700 MIME-Version: 1.0 In-Reply-To: <87oae8ix9b.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c0Gu8DsSIgm8sWLNdjun637NrHWecENbr" Subject: Re: [Qemu-devel] [PATCH v14 13/15] qapi: Enforce (or whitelist) case conventions on qapi members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c0Gu8DsSIgm8sWLNdjun637NrHWecENbr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/2015 10:19 AM, Markus Armbruster wrote: >> With your patch, the positive tests no longer work in isolation. You >> were getting lucky that things sorted such that 'Foo' was checked for >> correctness prior to 'UuidInfo'; but if you comment out the 'Foo' >> declaration, or rename from 'Foo' to something else that hashes after >> 'UuidInfo', then args-member-case and union-branch-case start reportin= g >> failures about UuidInfo (and only enum-member-case honors the >> whitelist). >=20 > You're right. >=20 >> +++ w/tests/qapi-schema/args-member-case.json >> @@ -1,3 +1,3 @@ >> # Member names should be 'lower-case' unless the struct/command is >> whitelisted >> -{ 'command': 'UuidInfo', 'data': { 'Arg': 'int' } } >> +{ 'command': 'x-UuidInfo', 'data': { 'Arg': 'int' } } >=20 > Will fail as soon as we enforce the command naming convention. To avoi= d > that, we need to add a suitable name to the whitelist. >=20 > However, we don't actually have any command parameters to whitelist. > Why bother testing it then? Good point. >=20 >>>From 44f07a40c8b9b5d1f24833028b5dacde1fd50c80 Mon Sep 17 00:00:00 2001 > From: Markus Armbruster > Date: Wed, 2 Dec 2015 17:41:55 +0100 > Subject: [PATCH] fixup! qapi: Enforce (or whitelist) case conventions o= n qapi > members >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 6 ++---- > tests/qapi-schema/args-member-case.err | 2 +- > tests/qapi-schema/args-member-case.json | 3 +-- > tests/qapi-schema/enum-member-case.err | 2 +- > tests/qapi-schema/enum-member-case.json | 4 ++-- > tests/qapi-schema/union-branch-case.err | 2 +- > tests/qapi-schema/union-branch-case.json | 3 +-- > 7 files changed, 9 insertions(+), 13 deletions(-) Looks good. Commit 6c1eb345 on your qapi-not-next branch has this already squashed in, but lacking your S-o-b. But that only affects the commit message, so I'll go ahead and base my future patch submissions on top of the current contents of qapi-not-next (it will be interesting to see how many patches land from various trees right after 2.6 opens up...)= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --c0Gu8DsSIgm8sWLNdjun637NrHWecENbr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWX0njAAoJEKeha0olJ0Nqhb8H/ifTfGrs1lAZuIV5USycRU5l wV2pjYPPJEMRN5qm7iKrDSWlRYmWz/rUk3p52/XK7tjzYExvs36TsO+ujsYPhxT4 sYPhWa4uU4Md26gHIM3aSHpx4klrCj5I6xfbtN7jxsI8NhZ1WU3FsjnHYNcOci8g nJ21l7/zEGi7JAXV93mhAEFytMEjoh8EPMnIIE5MiFw5P6J3e3bRwznyVJPpkJfZ 51xtX62YbLhPDdTuebnRJSu6iMhG+M94TcVaF3ZpEtQ3bDDTVgDVTybp2JzGwOVw OfzvnfPVnhCPEUG5q/wKRMHMNdVDBvU9cRg5dqVrGgdLUAygALRG1KLMTRyEuYw= =XgYC -----END PGP SIGNATURE----- --c0Gu8DsSIgm8sWLNdjun637NrHWecENbr--