From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4GM6-0007lc-9V for qemu-devel@nongnu.org; Wed, 02 Dec 2015 17:58:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4GM5-0003H9-Bs for qemu-devel@nongnu.org; Wed, 02 Dec 2015 17:58:34 -0500 Message-ID: <565F7793.4090707@gmail.com> Date: Wed, 02 Dec 2015 17:58:27 -0500 From: Michael Davidsaver MIME-Version: 1.0 References: <1447031505-12477-1-git-send-email-mdavidsaver@gmail.com> <1447031505-12477-6-git-send-email-mdavidsaver@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/18] armv7m: expand NVIC state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , qemu-arm@nongnu.org, QEMU Developers On 11/17/2015 01:10 PM, Peter Maydell wrote: > On 9 November 2015 at 01:11, Michael Davidsaver wrote: >> Expand the NVIC to fully support -M priorities and masking. >> Doesn't use GIC code. >> >> Move some state to ARMCPU to allow calculation of exception masking. >> >> Add storage for PRIGROUP to configure group/sub-group split. >> Track group and sub-group in separate fields for quick comparison. >> Mix in vector # with sub-group as per tie breaking rules. >> >> NVIC now derives directly from SysBusDevice, and >> struct NVICClass is eliminated. >> >> Also add DPRINTF() macro. >> >> Signed-off-by: Michael Davidsaver > > This patch doesn't compile, because you've removed the definition of > NVICClass, NVIC_CLASS, etc, but not their uses. A patchset needs to > compile after every patch in it, not just at the end when all patches > are applied. You'll need to rearrange your changes between patches > a bit. In the next rev. I've rearranged things so that each patches compiles. At least according to 'git rebase -i -x make', so not a full rebuilt. This does mean that the big block of changes to the NVIC are now almost entirely in one patch as I couldn't see how to split them up given that the nvic_state structure is changed so much.