From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly
Date: Thu, 3 Dec 2015 09:45:56 -0700 [thread overview]
Message-ID: <566071C4.30706@redhat.com> (raw)
In-Reply-To: <1449160660-3777-2-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
On 12/03/2015 09:37 AM, Markus Armbruster wrote:
> Since prop_get_fdt() is only used with QmpOutputVisitor, errors
> shouldn't actually happen, so this is only a latent bug.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/ppc/spapr_drc.c | 32 ++++++++++++++++++++++++++------
> 1 file changed, 26 insertions(+), 6 deletions(-)
I posted a similar patch, but using &error_abort rather than
propagating, here:
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg05788.html
But I like yours better.
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index f34bc04..4e7a1d3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-12-03 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 16:37 [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes Markus Armbruster
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly Markus Armbruster
2015-12-03 16:45 ` Eric Blake [this message]
2015-12-03 23:45 ` David Gibson
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} Markus Armbruster
2015-12-03 16:54 ` Eric Blake
2015-12-03 17:13 ` Markus Armbruster
2015-12-03 17:30 ` Eric Blake
2015-12-03 17:55 ` Markus Armbruster
2015-12-04 13:22 ` Eric Blake
2015-12-03 23:54 ` David Gibson
2015-12-04 2:41 ` Eric Blake
2015-12-04 5:50 ` David Gibson
2015-12-04 8:15 ` Markus Armbruster
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device Markus Armbruster
2015-12-03 16:55 ` Eric Blake
2015-12-03 17:18 ` Thomas Huth
2015-12-03 23:55 ` David Gibson
2015-12-03 18:15 ` [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes Markus Armbruster
2015-12-03 23:57 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566071C4.30706@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).