From: Thomas Huth <thuth@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device
Date: Thu, 3 Dec 2015 18:18:22 +0100 [thread overview]
Message-ID: <5660795E.7040802@redhat.com> (raw)
In-Reply-To: <1449160660-3777-4-git-send-email-armbru@redhat.com>
On 03/12/15 17:37, Markus Armbruster wrote:
> It should only be created via spapr_dr_connector_new(). Attempting to
> create it with -device crashes.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/ppc/spapr_drc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index dad157f..8be62c3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data)
> drck->attach = attach;
> drck->detach = detach;
> drck->release_pending = release_pending;
> + /*
> + * Reason: it crashes FIXME find and document the real reason
> + */
> + dk->cannot_instantiate_with_device_add_yet = true;
> }
>
> static const TypeInfo spapr_dr_connector_info = {
That fix should be fine for 2.5.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2015-12-03 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 16:37 [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes Markus Armbruster
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 1/3] spapr_drc: Handle visitor errors properly Markus Armbruster
2015-12-03 16:45 ` Eric Blake
2015-12-03 23:45 ` David Gibson
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} Markus Armbruster
2015-12-03 16:54 ` Eric Blake
2015-12-03 17:13 ` Markus Armbruster
2015-12-03 17:30 ` Eric Blake
2015-12-03 17:55 ` Markus Armbruster
2015-12-04 13:22 ` Eric Blake
2015-12-03 23:54 ` David Gibson
2015-12-04 2:41 ` Eric Blake
2015-12-04 5:50 ` David Gibson
2015-12-04 8:15 ` Markus Armbruster
2015-12-03 16:37 ` [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device Markus Armbruster
2015-12-03 16:55 ` Eric Blake
2015-12-03 17:18 ` Thomas Huth [this message]
2015-12-03 23:55 ` David Gibson
2015-12-03 18:15 ` [Qemu-devel] [PATCH for-2.5 0/3] spapr_drc: Last minute bug fixes Markus Armbruster
2015-12-03 23:57 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5660795E.7040802@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).