From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4XWY-000806-QB for qemu-devel@nongnu.org; Thu, 03 Dec 2015 12:18:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4XWV-0004R0-EP for qemu-devel@nongnu.org; Thu, 03 Dec 2015 12:18:30 -0500 References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-4-git-send-email-armbru@redhat.com> From: Thomas Huth Message-ID: <5660795E.7040802@redhat.com> Date: Thu, 3 Dec 2015 18:18:22 +0100 MIME-Version: 1.0 In-Reply-To: <1449160660-3777-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.5 3/3] spapr_drc: Make device "spapr-dr-connector" unavailable with -device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, agraf@suse.de, david@gibson.dropbear.id.au On 03/12/15 17:37, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. > > Signed-off-by: Markus Armbruster > --- > hw/ppc/spapr_drc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c > index dad157f..8be62c3 100644 > --- a/hw/ppc/spapr_drc.c > +++ b/hw/ppc/spapr_drc.c > @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClass *k, void *data) > drck->attach = attach; > drck->detach = detach; > drck->release_pending = release_pending; > + /* > + * Reason: it crashes FIXME find and document the real reason > + */ > + dk->cannot_instantiate_with_device_add_yet = true; > } > > static const TypeInfo spapr_dr_connector_info = { That fix should be fine for 2.5. Reviewed-by: Thomas Huth