From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4XiV-0005Q7-Ol for qemu-devel@nongnu.org; Thu, 03 Dec 2015 12:30:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4XiQ-0000y0-Or for qemu-devel@nongnu.org; Thu, 03 Dec 2015 12:30:51 -0500 References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-3-git-send-email-armbru@redhat.com> <566073CE.8090601@redhat.com> <87r3j3jw0l.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56607C3E.8000100@redhat.com> Date: Thu, 3 Dec 2015 10:30:38 -0700 MIME-Version: 1.0 In-Reply-To: <87r3j3jw0l.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sa3TGq9KqhlLKiMcGaBDjDnB2eC25277o" Subject: Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sa3TGq9KqhlLKiMcGaBDjDnB2eC25277o Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2015 10:13 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 12/03/2015 09:37 AM, Markus Armbruster wrote: >>> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't >>> visit anything. object_property_get_qobject() happily >>> object_property_get_qobject(). Amazingly, the latter survives the >> >> Something got lost or otherwise corrupted in that sentence. Were you >> trying to say one function happily calls another? If so, which of the= >> two "object_property_get_qobject()" strings should be changed, to what= ? >=20 > No idea what happened. Correction: insert "calls" after "happily": >=20 > prop_get_fdt() misuses the visitor API: when fdt is null, it doesn'= t > visit anything. object_property_get_qobject() happily calls > object_property_get_qobject(). That still reads "A() happily calls A()" - are we talking about recursion here? I still wonder if you meant a second function name, and/or mention of the fact that we are calling a function with NULL rather than a QObject? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sa3TGq9KqhlLKiMcGaBDjDnB2eC25277o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYHw+AAoJEKeha0olJ0Nq/O0IAK/cNDlGE/s+elO35uW1TuAq dvZGq+B3AZQNCoPI7HTv0gj6K4Z3HRj9I6kGjOd4R+1XSQctCTrZFFJ3zVUOkUTr H0tvI/GomX713VgIMQSI0yD2/PD/jWI0CFIc6LJFTWGVUf/wQ6HFy7n3+uv+Ao3K SpYbRkZRyI2DOu/oznw/F6UjgnyRpLttaWor1LZMSiX2yG0/NxdTCTmWt2DELn1s XGjAC0i4SstMvG9fij3ehzc8p/ZlHwHvsv8jlUt0h8A1Wkc97UBP03n+dnK1Z83z 6saO3fuoGadfMoaKimB8KSNRoclYl7I6pjTTI4RDfV+a+Dsv6odHgMPZuWKi1Ds= =haxH -----END PGP SIGNATURE----- --sa3TGq9KqhlLKiMcGaBDjDnB2eC25277o--