From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4gpi-00006b-9Y for qemu-devel@nongnu.org; Thu, 03 Dec 2015 22:14:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4gpd-0007q4-5o for qemu-devel@nongnu.org; Thu, 03 Dec 2015 22:14:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4gpd-0007py-0v for qemu-devel@nongnu.org; Thu, 03 Dec 2015 22:14:49 -0500 References: <1449119286-57280-1-git-send-email-yanmiaobest@gmail.com> From: Jason Wang Message-ID: <5661051F.3020401@redhat.com> Date: Fri, 4 Dec 2015 11:14:39 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Fleytman , Miao Yan Cc: qemu-devel@nongnu.org On 12/03/2015 03:24 PM, Dmitry Fleytman wrote: > Acked-by: Dmitry Fleytman > Applied in my -net for 2.5. Thanks > >> On 3 Dec 2015, at 07:08 AM, Miao Yan > > wrote: >> >> Macro MAC_FMT and MAC_ARG are not defined, but used in >> vmxnet3_net_init(). >> This will cause build error when debug level is raised in >> vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). >> >> Use VMXNET_MF and VXMNET_MA instead. >> >> Signed-off-by: Miao Yan > > >> --- >> hw/net/vmxnet3.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c >> index 5e3a233..ea3d9b7 100644 >> --- a/hw/net/vmxnet3.c >> +++ b/hw/net/vmxnet3.c >> @@ -2044,7 +2044,7 @@ static void vmxnet3_net_init(VMXNET3State *s) >> >> s->link_status_and_speed = VMXNET3_LINK_SPEED | >> VMXNET3_LINK_STATUS_UP; >> >> - VMW_CFPRN("Permanent MAC: " MAC_FMT, MAC_ARG(s->perm_mac.a)); >> + VMW_CFPRN("Permanent MAC: " VMXNET_MF, VMXNET_MA(s->perm_mac.a)); >> >> s->nic = qemu_new_nic(&net_vmxnet3_info, &s->conf, >> object_get_typename(OBJECT(s)), >> -- >> 2.1.4 >> >