From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4pbT-0007ES-Ml for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:36:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4pbQ-0005op-FB for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:36:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4pbQ-0005oV-9F for qemu-devel@nongnu.org; Fri, 04 Dec 2015 07:36:44 -0500 References: <1449232131-17317-1-git-send-email-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <566188D8.6010002@redhat.com> Date: Fri, 4 Dec 2015 13:36:40 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On 04/12/2015 13:33, Peter Maydell wrote: > On 4 December 2015 at 12:28, Paolo Bonzini wrote: >> This is a first baby step towards removing widespread inclusion of >> cpu.h and compiling more devices once (so that arm, aarch64 and >> in the future target-multi can share the object files). >> >> Signed-off-by: Paolo Bonzini >> --- >> hw/dma/soc_dma.c | 37 ++++++++++++++++--------------------- >> 1 file changed, 16 insertions(+), 21 deletions(-) >> >> diff --git a/hw/dma/soc_dma.c b/hw/dma/soc_dma.c >> index c06aabb..ac395c5 100644 >> --- a/hw/dma/soc_dma.c >> +++ b/hw/dma/soc_dma.c >> @@ -269,11 +269,10 @@ void soc_dma_port_add_fifo(struct soc_dma_s *soc, hwaddr virt_base, >> if (entry->type == soc_dma_port_mem) { >> if (entry->addr <= virt_base && >> entry->addr + entry->u.mem.size > virt_base) { >> - fprintf(stderr, "%s: FIFO at " TARGET_FMT_lx >> - " collides with RAM region at " TARGET_FMT_lx >> - "-" TARGET_FMT_lx "\n", __FUNCTION__, >> - (target_ulong) virt_base, >> - (target_ulong) entry->addr, (target_ulong) >> + fprintf(stderr, "%s: FIFO at %"PRIx64 >> + " collides with RAM region at %"PRIx64 >> + "-%"PRIx64 "\n", __FUNCTION__, >> + virt_base, entry->addr, >> (entry->addr + entry->u.mem.size)); > > Is using the HWADDR_PRI* macros for printing hwaddrs deprecated now? It's the first time I hear about them. :) There are still 130-odd usages of HWADDR_PRIx and friends, so at least it's an incomplete transition. So I can use them if the maintainer tells me to. Paolo