From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qFV-0002Mu-PX for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:18:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4qFU-0004A8-MH for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:18:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qFU-00049z-HH for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:18:08 -0500 References: <1449220774-17968-1-git-send-email-yanmiaobest@gmail.com> From: Eric Blake Message-ID: <5661928A.1000700@redhat.com> Date: Fri, 4 Dec 2015 06:18:02 -0700 MIME-Version: 1.0 In-Reply-To: <1449220774-17968-1-git-send-email-yanmiaobest@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7VdHTWRtjJVjPFO2E5OotvtLfQcmejuTd" Subject: Re: [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miao Yan , jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7VdHTWRtjJVjPFO2E5OotvtLfQcmejuTd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/04/2015 02:19 AM, Miao Yan wrote: > Vmxnet3 uses the following debug macro style: >=20 When sending a patch series, it's best to include a 0/2 cover letter (some of the maintainer tooling works better if it can reply to the cover letter). Also, this patch depends on your earlier patch "net/vmxnet3.c: fix a build error when enabling debug output" in order to not cause a temporary compile failure; you should state that dependency so that the patches get applied in the correct order. (Or just make the series be 3 patches, with that one as 1/3) > #ifdef SOME_DEBUG > # define debug(...) do{ printf(...); } while (0) > # else > # define debug(...) do{ } while (0) > #endif >=20 > If SOME_DEBUG is undefined, then format string inside the > debug macro will never be checked by compiler. Code will > likely to break in the future when SOME_DEBUG is enabled s/will/is > because of lacking of testing. This patch changes this s/lacking/lack/ > to the following: >=20 > #define debug(...) \ > do { if (SOME_DEBUG_ENABLED) printf(...); } while (0) >=20 > Signed-off-by: Miao Yan > --- > hw/net/vmxnet_debug.h | 139 +++++++++++++++++++++++++++++++-----------= -------- > 1 file changed, 86 insertions(+), 53 deletions(-) >=20 Changes themselves look okay, so with the commit message grammar improved= , Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7VdHTWRtjJVjPFO2E5OotvtLfQcmejuTd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYZKKAAoJEKeha0olJ0Nq88sH/jIYBFiChsG6b0sgEFOSBiRc z+5sarTgS5ZS0OYkdVYCfJcWMiX9tW8duYndZgzl7RER50xCxlDO5r4i0YphHrgj R0pnsMrRePehxbYu6sYYyMa2gZCoUeNEUpWHD/+o0KLirFVC8q9Y4o/XB0Fj5gMW D+5BCqL+1+ftBFj75S8RzmpUGmfFvnMzLFWO0uzg52Fh4VBIjiNZ8dcw39K2GX4E R5Hk8Ozk3ngYlaXz4gaI7y3wu71Oih52Ob5gSpvS4Vds5x0mc30LUmi+vp2aNVjY 8Yg5UlA2ThEAKSw8EtP8pxf684hqRkEdO+ja/4wht4liJ3noeXwRxUHFW4RqGyQ= =LPRy -----END PGP SIGNATURE----- --7VdHTWRtjJVjPFO2E5OotvtLfQcmejuTd--