From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qJh-0006jm-Uv for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:22:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4qJe-0005b0-Mr for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:22:29 -0500 References: <1449160660-3777-1-git-send-email-armbru@redhat.com> <1449160660-3777-3-git-send-email-armbru@redhat.com> <566073CE.8090601@redhat.com> <87r3j3jw0l.fsf@blackfin.pond.sub.org> <56607C3E.8000100@redhat.com> <87r3j3fmcn.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56619390.3000306@redhat.com> Date: Fri, 4 Dec 2015 06:22:24 -0700 MIME-Version: 1.0 In-Reply-To: <87r3j3fmcn.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T3lkQCrgf6rcBHS2WNrfkr6v1UpJPSRxK" Subject: Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, agraf@suse.de, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T3lkQCrgf6rcBHS2WNrfkr6v1UpJPSRxK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2015 10:55 AM, Markus Armbruster wrote: > I'm incapable of proof-reading anything I wrote myself %-} I know the feeling :) >=20 > prop_get_fdt() misuses the visitor API: when fdt is null, it doesn'= t > visit anything. object_property_get_qobject() happily calls > qmp_output_get_qobject() then. Amazingly, the latter survives the > misuse. Turns out we've papered over it long before prop_get_fdt()= > existed, in commit 1d10b44. Oh well, it got pushed to master with original confusing spelling after all (commit ab8bf1d7). Not the end of the world :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T3lkQCrgf6rcBHS2WNrfkr6v1UpJPSRxK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYZOQAAoJEKeha0olJ0NqqJUIAKkCJ/jLfJqiy0rbklfK6BoQ 515ybRAuURrwttIgi/+APKf0pZ/AhedB32n0DciCLZYW2ZXQCimBP5GXr/VdT/PD EBHSmeJHjnsmIO0eo2pnbjDo4F8fr0lDgMHtOf0p+RejALH3Das3BgTe4yG0ImgG wDfoqrKQQAgx3eOduXwf6haiGtPznfW0B23ropCKcwhZfsQeQqa1XRUSn+j7jzf/ fK+u8LN+GigIVyS6SM0wmxDqqpiJ3QgHaQ5RuQAYiVaFU3vLsqEh20RAPH1hQaHJ +25EAXISeiNHY7h9LjKRIGAXmuDp6+5ipgAnhMMCZgLbJ4bOFazfI7BkWJxN7JI= =mDn+ -----END PGP SIGNATURE----- --T3lkQCrgf6rcBHS2WNrfkr6v1UpJPSRxK--