From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qWr-0007D1-QN for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4qWq-0002yf-Qe for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:36:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36946) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4qWq-0002yO-Lu for qemu-devel@nongnu.org; Fri, 04 Dec 2015 08:36:04 -0500 References: <1449220774-17968-1-git-send-email-yanmiaobest@gmail.com> <1449220774-17968-2-git-send-email-yanmiaobest@gmail.com> From: Eric Blake Message-ID: <566196BF.6080801@redhat.com> Date: Fri, 4 Dec 2015 06:35:59 -0700 MIME-Version: 1.0 In-Reply-To: <1449220774-17968-2-git-send-email-yanmiaobest@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WWrmj4lv7LVBw2NMgXQUqvivSFMsHgblq" Subject: Re: [Qemu-devel] [PATCH 2/2] net/vmxnet3: remove redundant VMW_SHPRN(...) definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miao Yan , jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WWrmj4lv7LVBw2NMgXQUqvivSFMsHgblq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/04/2015 02:19 AM, Miao Yan wrote: > Macro VMW_SHPRN(...) is already defined vmxnet3_debug.h, > so remove the duplication >=20 > Signed-off-by: Miao Yan > --- > hw/net/vmware_utils.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/hw/net/vmware_utils.h b/hw/net/vmware_utils.h > index 1099df6..c2c2f90 100644 > --- a/hw/net/vmware_utils.h > +++ b/hw/net/vmware_utils.h > @@ -18,10 +18,7 @@ > #define VMWARE_UTILS_H > =20 > #include "qemu/range.h" > - > -#ifndef VMW_SHPRN > -#define VMW_SHPRN(fmt, ...) do {} while (0) > -#endif > +#include "vmxnet_debug.h" > =20 > /* > * Shared memory access functions with byte swap support >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WWrmj4lv7LVBw2NMgXQUqvivSFMsHgblq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYZa/AAoJEKeha0olJ0Nq0SsH/3zi5Ci3v0P0wtW+POMgmy8j k5uHCg28md11wWt/McGX6qD3/12AF7fCVGSKf+zBbMGmM/UJLm/kf3GiwIlWfkRP kKokrGZDr8eEFuQnE9ErP4XMweCb/C6cEnKCnJl+biiwRonCRltdwrjk04utIN+y 30SWxCbahOsmhE22s+scLqfyI59alqVXyN3bjGAqYS6T1j4wOzFLuQaPDSm10FQ/ k+O626kce4311bWtPVJrapMTbIc4+51bSU8Sd7lW6YbzuB23rx+FFjjJGx/u60It 60IDz4z6XzSpH/iYXZl/EaJUvmRq5Ejl/B4dxrC6R5+xbVME5lgWzvT4LxZQg18= =fSTV -----END PGP SIGNATURE----- --WWrmj4lv7LVBw2NMgXQUqvivSFMsHgblq--