From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4xnS-0003DC-5x for qemu-devel@nongnu.org; Fri, 04 Dec 2015 16:21:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4xnP-0007Mk-3p for qemu-devel@nongnu.org; Fri, 04 Dec 2015 16:21:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4xnO-0007MP-Sz for qemu-devel@nongnu.org; Fri, 04 Dec 2015 16:21:39 -0500 References: <1449136891-26850-1-git-send-email-tubo@linux.vnet.ibm.com> <1449136891-26850-3-git-send-email-tubo@linux.vnet.ibm.com> From: Max Reitz Message-ID: <566203DD.9080005@redhat.com> Date: Fri, 4 Dec 2015 22:21:33 +0100 MIME-Version: 1.0 In-Reply-To: <1449136891-26850-3-git-send-email-tubo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OBG6KscMmQDvCci6bIB4IPfPKE2u7D0db" Subject: Re: [Qemu-devel] [PATCH v4 2/3] qemu-iotests: s390x: fix test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bo Tu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com, mimu@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OBG6KscMmQDvCci6bIB4IPfPKE2u7D0db Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.12.2015 11:01, Bo Tu wrote: > From: Bo Tu =20 >=20 > The tests for ide device should only be tested for the pc > platform. > Set device_id to "drive0", and replace every "-drive file..." > by "-drive file=3D...,if=3Dnone,id=3D$device_id", then x86 and s390x > can get the common output in the test of "Snapshot mode". > Warning message expected for s390x when drive without device. > A x86 platform specific output file is also needed. >=20 > Reviewed-by: Sascha Silbe > Signed-off-by: Bo Tu > --- > tests/qemu-iotests/051 | 95 ++++++---- > tests/qemu-iotests/051.out | 163 ++++------------ > tests/qemu-iotests/051.pc.out | 422 ++++++++++++++++++++++++++++++++++= ++++++++ > 3 files changed, 521 insertions(+), 159 deletions(-) > create mode 100644 tests/qemu-iotests/051.pc.out I like the overall design now, but I think we can do more still. As evidenced by changes in the reference output from "ide0-hd0" to "virtio0", there are still more places which are missing an explicit if (like if=3Dnone) and id in 051 and are thus currently subject to whatever= the target platform uses as the default (which happens to be virtio/virtio0 for s390). I think all of the places in 051 which do not specify an interface and ID should do so (i.e. if=3Dnone,id=3Ddrive0). Next, there are the warnings regarding orphaned drives. I'm only just now asking myself the question where they really come from, and I guess it's mostly the fact that we are trying to use if=3Dide, if=3Dfloppy and if=3Dscsi which do not seem to be supported by s390. I guess we should simply not do any of the tests which use any of these interfaces (or, phrased differently, only do tests which use if=3Dnone or if=3Dvirtio). I'd be willing to merge this patch now anyway, though, as long as there will be a follow-up patch addressing these issues, if you agree. Max --OBG6KscMmQDvCci6bIB4IPfPKE2u7D0db Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWYgPdAAoJEDuxQgLoOKytVkoH/iBTk47oUnbQdCo6vxl0+cAx /a/FNlxuqHxkGfXPKgCLy10MmMw+oza0By9pN27Y4jqtXEozjMnbdlliNZc0XSjV rMPGL+dq3pL5JQ0w4m8Xz3txoXoHEvOZ250nj4TZqYubdRvR1En1iSuuoY9RHHSg ZVCWbSSs5wqrjt2rQlbJ+lOnBVJYzSMU0AnBwxo2G68azu6wo9hO4X8r7gqHXMUk wRR86R96YO88I0OLfmiNWBmcPHcImGK+fOvX+DCyJaXZOXum1CufUZlvRCVE6o8S 4KNe8PG8UZywKMv4mRe5MihK/509wTvrFfI/PbLDTdAXC9H7+TwujN/Bst1t+a4= =EQ8+ -----END PGP SIGNATURE----- --OBG6KscMmQDvCci6bIB4IPfPKE2u7D0db--