From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56333) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4yNw-0006Qk-90 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 16:59:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4yNv-0002by-Bh for qemu-devel@nongnu.org; Fri, 04 Dec 2015 16:59:24 -0500 References: <1449236124-19605-1-git-send-email-kwolf@redhat.com> <1449236124-19605-15-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56620CB2.4010500@redhat.com> Date: Fri, 4 Dec 2015 22:59:14 +0100 MIME-Version: 1.0 In-Reply-To: <1449236124-19605-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IXHc3WdrHNS17XJEN6gdJio1rvrcOgFEF" Subject: Re: [Qemu-devel] [PATCH v3 14/21] blockdev: Set 'format' indicates non-empty drive List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IXHc3WdrHNS17XJEN6gdJio1rvrcOgFEF Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.12.2015 14:35, Kevin Wolf wrote: > Creating an empty drive while specifying 'format' doesn't make sense. > The specified format driver would simply be ignored. >=20 > Make a set 'format' option an indication that a non-empty drive should > be created. This makes 'format' consistent with 'driver' and allows > using it with a block driver that doesn't need any other options (like > null-co/null-aio). >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 5 +---- > tests/hd-geo-test.c | 4 ++-- > tests/qemu-iotests/iotests.py | 2 +- > 3 files changed, 4 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz --IXHc3WdrHNS17XJEN6gdJio1rvrcOgFEF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWYgyyAAoJEDuxQgLoOKytg8AH/A6i/XP2M1t7t9iBWjG/xoj4 owTGk6SrSuns52d3F3dFrY5g6DkMm1Hzxt9j5S7E4mtfzSOBxCcvAzbFeBHL2rKA 3MMLXfLISVWWNaNw47k3NzF/oFVrUYeg9qEOjwOyNEnh7Yf99GDTkbbxIIY0SPh5 EnlnuCuEx1XsVB3aaOQU6kitGTVG1a7RIP9UQ4O4ZjduRVyv1RIYT1OJ1+KqHP3d 7alvqAtJRRbmKhWq5ftSbsgdCVoz0W3iVuFpCA7LiEszIhn2ub9AdkJJVVcMJJpL wnCyUoarloaN/tKlabta2veAXFq7Fdo5gWJS6FG+aGmROVd/y1w+KEghgttlCVw= =uXwO -----END PGP SIGNATURE----- --IXHc3WdrHNS17XJEN6gdJio1rvrcOgFEF--