From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4yVX-0000lV-8x for qemu-devel@nongnu.org; Fri, 04 Dec 2015 17:07:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4yVW-0004zE-Dq for qemu-devel@nongnu.org; Fri, 04 Dec 2015 17:07:15 -0500 References: <1449236124-19605-1-git-send-email-kwolf@redhat.com> <1449236124-19605-18-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <56620E87.5070506@redhat.com> Date: Fri, 4 Dec 2015 23:07:03 +0100 MIME-Version: 1.0 In-Reply-To: <1449236124-19605-18-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XR2KGbVxCtt7LRScoBbiF4Llgxu8rIotB" Subject: Re: [Qemu-devel] [PATCH v3 17/21] block: Move cache options into options QDict List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XR2KGbVxCtt7LRScoBbiF4Llgxu8rIotB Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.12.2015 14:35, Kevin Wolf wrote: > This adds the cache mode options to the QDict, so that they can be > specified for child nodes (e.g. backing.cache.direct=3Doff). >=20 > The cache modes are not removed from the flags at this point; instead, > options and flags are kept in sync. If the user specifies both flags an= d > options, the options take precedence. >=20 > Child node inherit cache modes as options now, they don't use flags any= > more. >=20 > Note that this forbids specifying the cache mode for empty drives. It > didn't make sense anyway to specify it there, because it didn't have an= y > effect. blockdev_init() considers the cache options now bdrv_open() > options and therefore doesn't create an empty drive any more but calls > into bdrv_open(). This in turn will fail with no driver and filename > specified. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++--- > blockdev.c | 52 ++++++++++---------------------- > 2 files changed, 111 insertions(+), 41 deletions(-) Reviewed-by: Max Reitz --XR2KGbVxCtt7LRScoBbiF4Llgxu8rIotB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWYg6HAAoJEDuxQgLoOKytwdMH/R9x54cVD4dDWXtP5x8hT8SF wXB6CMH2MVhZDgFGATAOtPXpwUaGEIkkzeXbuv1A5xig4Zu2LzeaLJtkXTN5p+lC IGANGIbEztM2U9X+Q8Pd0Zrdt+epn4zfvgPpvhEWt2hlsPMsuA3vZ0gyRL9Zo5fn AJSUU0E/Q2MSgJ2MDRtcQ0CixmnGtPFp/DK+aj7PUwkiMKDxt0KMWVfkn5+iIX09 oj8XRlkhN6YB2Eivp2XrC3gdCi3M6p8xf5Is1msOfr9u1fV2Pla6JfFbWVlu38Fj QDEEy61Dybk6H5+rYWiGfhdP/bRa+FSsKT7x9u1hayeDDLFJtmWj+NO6NzE83NE= =ye5t -----END PGP SIGNATURE----- --XR2KGbVxCtt7LRScoBbiF4Llgxu8rIotB--