From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4yiy-0006RT-RJ for qemu-devel@nongnu.org; Fri, 04 Dec 2015 17:21:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4yiu-0008SF-T9 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 17:21:08 -0500 Received: from e18.ny.us.ibm.com ([129.33.205.208]:58083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4yiu-0008S9-Q2 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 17:21:04 -0500 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Dec 2015 17:21:02 -0500 Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id D19746E8040 for ; Fri, 4 Dec 2015 17:09:10 -0500 (EST) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tB4ML1o826148890 for ; Fri, 4 Dec 2015 22:21:01 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tB4MIN4n015605 for ; Fri, 4 Dec 2015 17:18:24 -0500 References: <1449136891-26850-1-git-send-email-tubo@linux.vnet.ibm.com> <1449136891-26850-3-git-send-email-tubo@linux.vnet.ibm.com> <566203DD.9080005@redhat.com> From: Bo Tu Message-ID: <566211BE.4080104@linux.vnet.ibm.com> Date: Sat, 5 Dec 2015 06:20:46 +0800 MIME-Version: 1.0 In-Reply-To: <566203DD.9080005@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 2/3] qemu-iotests: s390x: fix test 051 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com, mimu@linux.vnet.ibm.com Hi Max: 在 2015/12/5 5:21, Max Reitz 写道: > On 03.12.2015 11:01, Bo Tu wrote: >> From: Bo Tu >> >> The tests for ide device should only be tested for the pc >> platform. >> Set device_id to "drive0", and replace every "-drive file..." >> by "-drive file=...,if=none,id=$device_id", then x86 and s390x >> can get the common output in the test of "Snapshot mode". >> Warning message expected for s390x when drive without device. >> A x86 platform specific output file is also needed. >> >> Reviewed-by: Sascha Silbe >> Signed-off-by: Bo Tu >> --- >> tests/qemu-iotests/051 | 95 ++++++---- >> tests/qemu-iotests/051.out | 163 ++++------------ >> tests/qemu-iotests/051.pc.out | 422 ++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 521 insertions(+), 159 deletions(-) >> create mode 100644 tests/qemu-iotests/051.pc.out > > I like the overall design now, but I think we can do more still. > > As evidenced by changes in the reference output from "ide0-hd0" to > "virtio0", there are still more places which are missing an explicit if > (like if=none) and id in 051 and are thus currently subject to whatever > the target platform uses as the default (which happens to be > virtio/virtio0 for s390). I think all of the places in 051 which do not > specify an interface and ID should do so (i.e. if=none,id=drive0). > > Next, there are the warnings regarding orphaned drives. I'm only just > now asking myself the question where they really come from, and I guess > it's mostly the fact that we are trying to use if=ide, if=floppy and > if=scsi which do not seem to be supported by s390. I guess we should > simply not do any of the tests which use any of these interfaces (or, > phrased differently, only do tests which use if=none or if=virtio). > > I'd be willing to merge this patch now anyway, though, as long as there > will be a follow-up patch addressing these issues, if you agree. I will create a follow-up patch to address these issues you mentioned. thanks a lot for your review!! Have a good weekend. > > Max >