From: Max Reitz <mreitz@redhat.com>
To: Bo Tu <tubo@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, silbe@linux.vnet.ibm.com, armbru@redhat.com,
mimu@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v4 0/3] Update tests/qemu-iotests failing cases for the s390 platform
Date: Sat, 5 Dec 2015 00:32:37 +0100 [thread overview]
Message-ID: <56622295.9070701@redhat.com> (raw)
In-Reply-To: <566206EC.90105@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2413 bytes --]
On 04.12.2015 22:34, Max Reitz wrote:
> On 03.12.2015 11:01, Bo Tu wrote:
>> From: Bo Tu <tubo@linux.vnet.ibm.com>
>>
>> v4:
>> 1. Remove 051.s390.out, and rollback the changes in Makefile to generate
>> 051.s390-ccw-virtio.out
>> 2. Use 051.out as the common output for any non-pc platform
>> 3. Set device_id to "drive0", and replace every "-drive file..."
>> by "-drive file=...,if=none,id=$device_id", then x86 and s390x
>> can get the common output in the test of "Snapshot mode" for test 051
>> 4. Update 051.out and 051.pc.out
>>
>> v3:
>> 1. Remove patch for test 120 because Fam Zheng upstreamed same fix for
>> test 119 and 120
>> 2. Rename 051.out to 051.s390.out, add rule in Makefile to generate
>> 051.s390-ccw-virtio.out
>> 3. Remove superfluous quotation marks in common.config
>> 4. Add "Acked-by: Max Reitz <mreitz@redhat.com>" for test 068,
>> add "Reviewed-by: Max Reitz <mreitz@redhat.com>" for test 051 and common.config
>>
>> v2:
>> 1. Refine common.config via changing the definition of default_alias_machine
>> and default_machine
>> 2. Add Reviewed-by of Eric Blake for common.config
>>
>> v1:
>> 1. Refine common.config
>> 2. Update the output file for test 051 based on its current
>> output for s390 platform, add a pc specific output file for test 051
>> 3. checkpatch.pl reports invaid UTF-8 error for 051 patch,
>> because its output files contain some non-text data
>> 4. Add the parameter of "-no-shutdown -machine accel=kvm" for
>> s390-ccw-virtio for test 068
>> 5. Disable VNC server for test 120
>>
>> Bo Tu (3):
>> qemu-iotests: refine common.config
>> qemu-iotests: s390x: fix test 051
>> qemu-iotests: s390x: fix test 068
>>
>> tests/qemu-iotests/051 | 95 +++++----
>> tests/qemu-iotests/051.out | 163 ++++-----------
>> tests/qemu-iotests/051.pc.out | 422 +++++++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/068 | 14 +-
>> tests/qemu-iotests/common.config | 9 +-
>> 5 files changed, 537 insertions(+), 166 deletions(-)
>> create mode 100644 tests/qemu-iotests/051.pc.out
>
> Thanks, applied patches 1 and 3 to my block-next branch:
>
> https://github.com/XanClic/qemu/commits/block-next
>
> (And I will apply patch 2, too, depending on whether you agree to send a
> follow-up to it or respin once more.)
And now patch 2 has been applied, too.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-12-04 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 10:01 [Qemu-devel] [PATCH v4 0/3] Update tests/qemu-iotests failing cases for the s390 platform Bo Tu
2015-12-03 10:01 ` [Qemu-devel] [PATCH v4 1/3] qemu-iotests: refine common.config Bo Tu
2015-12-03 10:01 ` [Qemu-devel] [PATCH v4 2/3] qemu-iotests: s390x: fix test 051 Bo Tu
2015-12-04 21:21 ` Max Reitz
2015-12-04 22:20 ` Bo Tu
2015-12-03 10:01 ` [Qemu-devel] [PATCH v4 3/3] qemu-iotests: s390x: fix test 068 Bo Tu
2015-12-04 21:34 ` [Qemu-devel] [PATCH v4 0/3] Update tests/qemu-iotests failing cases for the s390 platform Max Reitz
2015-12-04 23:32 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56622295.9070701@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
--cc=tubo@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).