From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Fl9-0002zY-G5 for qemu-devel@nongnu.org; Sat, 05 Dec 2015 11:32:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5Fl6-0001nR-AN for qemu-devel@nongnu.org; Sat, 05 Dec 2015 11:32:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5Fl6-0001nK-4Y for qemu-devel@nongnu.org; Sat, 05 Dec 2015 11:32:28 -0500 References: <1449305702-2122-1-git-send-email-yanmiaobest@gmail.com> <1449305702-2122-2-git-send-email-yanmiaobest@gmail.com> From: Eric Blake Message-ID: <56631195.8020107@redhat.com> Date: Sat, 5 Dec 2015 09:32:21 -0700 MIME-Version: 1.0 In-Reply-To: <1449305702-2122-2-git-send-email-yanmiaobest@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AVVxJLMgOLP8W1MUx7vUGNNp2KVpwE0fP" Subject: Re: [Qemu-devel] [PATCH v2 1/3] net/vmxnet3.c: fix a build error when enabling debug output List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miao Yan , jasowang@redhat.com, dmitry@daynix.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AVVxJLMgOLP8W1MUx7vUGNNp2KVpwE0fP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/05/2015 01:55 AM, Miao Yan wrote: > Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init= (). > This will cause build error when debug level is raised in > vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). >=20 > Use VMXNET_MF and VXMNET_MA instead. >=20 > Signed-off-by: Miao Yan > --- > hw/net/vmxnet3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c > index 5e3a233..ea3d9b7 100644 > --- a/hw/net/vmxnet3.c > +++ b/hw/net/vmxnet3.c > @@ -2044,7 +2044,7 @@ static void vmxnet3_net_init(VMXNET3State *s) > =20 > s->link_status_and_speed =3D VMXNET3_LINK_SPEED | VMXNET3_LINK_STA= TUS_UP; > =20 > - VMW_CFPRN("Permanent MAC: " MAC_FMT, MAC_ARG(s->perm_mac.a)); > + VMW_CFPRN("Permanent MAC: " VMXNET_MF, VMXNET_MA(s->perm_mac.a)); > =20 > s->nic =3D qemu_new_nic(&net_vmxnet3_info, &s->conf, > object_get_typename(OBJECT(s)), >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AVVxJLMgOLP8W1MUx7vUGNNp2KVpwE0fP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWYxGVAAoJEKeha0olJ0NqQgkIAICTXuBOXZQChet5AdzMwpzS 8LpaIxYpLEQ09xLK4aG/7LZsJK59CRusCiifdZJDdgoeahax0a/juvuxXQvCf5v3 /eNms5/jBHEeCA7urBN7jQq6DzEjWwsx6I4x3AeqatpyNpoROB5VvxGVSZUBCQk/ R4mpwvNOKwbwdMiJzMhH+VU/l5aWgCAlfp4XJ+8+23R9rUltxvdXtdQLx3jxIE7k HNYfxLjNIwK0Gg9us86dKtsIdz3GfcpcCRql7ufrCHSEi1DDwJXloBqfjkjJLCYr gJWekaiBbwbo8LgYM1KI/ucJmFaS6m/IC5/9gX4rsOt+992P41nlst8oFkhptbk= =U9Rw -----END PGP SIGNATURE----- --AVVxJLMgOLP8W1MUx7vUGNNp2KVpwE0fP--