From: Jason Wang <jasowang@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Thomas Huth <thuth@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan'
Date: Mon, 14 May 2018 15:55:40 +0800 [thread overview]
Message-ID: <56637a3e-1566-2385-8dec-7fb3bf8c5fc2@redhat.com> (raw)
In-Reply-To: <20180503122122.GG5301@stefanha-x1.localdomain>
On 2018年05月03日 20:21, Stefan Hajnoczi wrote:
> On Mon, Apr 30, 2018 at 08:02:22PM +0200, Thomas Huth wrote:
>> The 'vlan' term caused a lot of confusion and misconfigurations in the
>> past. The parameter has been marked as deprecated since QEMU v2.9.0, so
>> it's now time to finally remove the parameter and use the better word "hub"
>> in the remaining spots that actually mean the QEMU emulated hub feature.
>>
>> v4:
>> - Some rewordings in qemu-doc.texi and qemu-options.hx according to
>> Stefan's and Paolo's suggestions
>>
>> v3:
>> - Some rewordings in qemu-doc and net.json according to Paolo's suggestions
>>
>> v2:
>> - Added first patch to actually remove the deprecated 'vlan' parameter
>> (instead of only updating the wording in the sources and docs)
>>
>> Thomas Huth (3):
>> net: Remove the deprecated "vlan" parameter
>> net: Get rid of 'vlan' terminology and use 'hub' instead in the source
>> files
>> net: Get rid of 'vlan' terminology and use 'hub' instead in the doc
>> files
>>
>> docs/qdev-device-use.txt | 3 --
>> hw/core/qdev-properties-system.c | 80 ----------------------------------------
>> include/hw/qdev-properties.h | 3 --
>> include/net/net.h | 1 -
>> net/hub.c | 7 ++--
>> net/net.c | 12 ++----
>> net/slirp.c | 8 ++--
>> net/tap.c | 4 +-
>> qapi/net.json | 15 ++++----
>> qemu-doc.texi | 51 ++++++++++++-------------
>> qemu-options.hx | 29 ++++++---------
>> 11 files changed, 54 insertions(+), 159 deletions(-)
>>
>> --
>> 1.8.3.1
>>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2018-05-14 7:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 18:02 [Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan' Thomas Huth
2018-04-30 18:02 ` [Qemu-devel] [PATCH v4 1/3] net: Remove the deprecated "vlan" parameter Thomas Huth
2018-04-30 18:02 ` [Qemu-devel] [PATCH v4 2/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the source files Thomas Huth
2018-04-30 18:02 ` [Qemu-devel] [PATCH v4 3/3] net: Get rid of 'vlan' terminology and use 'hub' instead in the doc files Thomas Huth
2018-05-03 12:21 ` [Qemu-devel] [PATCH v4 0/3] net: Get rid of 'vlan' Stefan Hajnoczi
2018-05-14 7:55 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56637a3e-1566-2385-8dec-7fb3bf8c5fc2@redhat.com \
--to=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).