From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1a5ljh-0003uo-5c
	for qemu-devel@nongnu.org; Sun, 06 Dec 2015 21:41:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1a5ljd-00017p-2A
	for qemu-devel@nongnu.org; Sun, 06 Dec 2015 21:41:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35435)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1a5ljc-00017Z-U7
	for qemu-devel@nongnu.org; Sun, 06 Dec 2015 21:41:05 -0500
References: <1449069991-6109-1-git-send-email-shmulik.ladkani@ravellosystems.com>
	<1449069991-6109-2-git-send-email-shmulik.ladkani@ravellosystems.com>
	<56615393.6020703@redhat.com> <20151204213802.6be55871@halley>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <5664F1B0.5000200@redhat.com>
Date: Mon, 7 Dec 2015 10:40:48 +0800
MIME-Version: 1.0
In-Reply-To: <20151204213802.6be55871@halley>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/5] vmxnet3: Change offsets of msi/msix
 pci capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Marcel Apfelbaum <marcel@redhat.com>, idan.brown@ravellosystems.com, qemu-devel@nongnu.org



On 12/05/2015 03:38 AM, Shmulik Ladkani wrote:
> Thanks Jason,
>
> On Fri, 4 Dec 2015 16:49:23 +0800 Jason Wang <jasowang@redhat.com> wrote:
>>> @@ -18,6 +18,10 @@
>>>              .driver   = "virtio-pci",\
>>>              .property = "migrate-extra",\
>>>              .value    = "off",\
>>> +        },{\
>>> +            .driver   = "vmxnet3",\
>>> +            .property = "x-old-msi-offsets",\
>>> +            .value    = "on",\
>>>          },
>> To have a better bisection behavior, we'd better enable this and compat
>> it in patch 2.
> Did you mean the following:
>
> #1 Introduce the new functionality with its 'x-old-msi-offsets'
>    property, with the property set to true by default
>
> #2 Change 'x-old-msi-offsets' default value to false, and introduce the
>    above compat
>
> Regards,
> Shmulik

Sorry for being unclear, I mean we'd better, keep the compat flag like
what has been done in the patch but introduce the property bit and
compat it in next patch.