From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5q3w-0003MW-Ew for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:18:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5q3v-0007j0-Do for qemu-devel@nongnu.org; Mon, 07 Dec 2015 02:18:20 -0500 Message-ID: <566530D2.8030507@huawei.com> Date: Mon, 7 Dec 2015 15:10:10 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1447680189-2128-1-git-send-email-shannon.zhao@linaro.org> <1447680189-2128-7-git-send-email-shannon.zhao@linaro.org> <20151204151004.7be15b36@nial.brq.redhat.com> In-Reply-To: <20151204151004.7be15b36@nial.brq.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/8] hw/arm/virt-acpi-build: Add _E03 for Power Button List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , shannon.zhao@linaro.org Cc: wei@redhat.com, peter.maydell@linaro.org, graeme.gregory@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, qemu-arm@nongnu.org On 2015/12/4 22:10, Igor Mammedov wrote: > On Mon, 16 Nov 2015 21:23:07 +0800 > shannon.zhao@linaro.org wrote: > >> From: Shannon Zhao >> >> Here GPIO pin 3 is used for Power Button, add _E03 in ACPI DSDT table. >> >> Signed-off-by: Shannon Zhao >> Signed-off-by: Shannon Zhao >> Tested-by: Wei Huang >> --- >> hw/arm/virt-acpi-build.c | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> index b25c90b..12c9e8b 100644 >> --- a/hw/arm/virt-acpi-build.c >> +++ b/hw/arm/virt-acpi-build.c >> @@ -337,6 +337,19 @@ static void acpi_dsdt_add_gpio(Aml *scope, const MemMapEntry *gpio_memmap, >> aml_append(crs, aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH, >> AML_EXCLUSIVE, gpio_irq)); >> aml_append(dev, aml_name_decl("_CRS", crs)); >> + >> + Aml *aei = aml_resource_template(); >> + /* Pin 3 for power button */ >> + int32_t pin_num[1] = {3}; >> + aml_append(aei, aml_gpio_int(AML_CONSUMER_PRODUCER, AML_EDGE, >> + AML_ACTIVE_HIGH, AML_EXCLUSIVE, AML_PULL_UP, 0, >> + pin_num, 1, "GPO0", NULL)); >> + aml_append(dev, aml_name_decl("_AEI", aei)); >> + >> + /* _E03 is handle for power button */ >> + Aml *method = aml_method("_E03", 0); >> + aml_append(method, aml_notify(aml_name("PWRB"), aml_int(0x80))); > you use "PWRB" here the second time, perhaps it would be better to use macro > #define ACPI_POWER_BUTTON_DEVICE "PWRB" > Sure, thanks! -- Shannon