From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Baumann <Andrew.Baumann@microsoft.com>,
Jason Wang <jasowang@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting
Date: Mon, 7 Dec 2015 10:52:39 +0100 [thread overview]
Message-ID: <566556E7.6000000@redhat.com> (raw)
In-Reply-To: <BLUPR0301MB20344A79C566F7A02B3D7EA39E090@BLUPR0301MB2034.namprd03.prod.outlook.com>
On 07/12/2015 06:20, Andrew Baumann wrote:
> Yeah, I considered doing that, but figured that those cases
> (incorrectly-sized register writes in 16-bit mode) are indicative of
> a pretty badly screwed-up guest, and was going for a minimal patch.
> It probably makes sense to change them for consistency, though.
I think those should be fixed by modifying lan9118_*_mem_ops and adding
.valid.{min,max}_access_size. Not for 2.5, however. (Probably these
patches should also be 2.6 + qemu-stable rather than 2.5).
Paolo
next prev parent reply other threads:[~2015-12-07 9:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 18:58 [Qemu-devel] [PATCH 0/2] minor fixes to lan9118 emulation Andrew Baumann
2015-12-04 18:58 ` [Qemu-devel] [PATCH 1/2] lan9118: fix emulation of MAC address loaded bit in E2P_CMD register Andrew Baumann
2015-12-07 2:42 ` Jason Wang
2015-12-04 18:58 ` [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting Andrew Baumann
2015-12-07 2:43 ` Jason Wang
2015-12-07 5:20 ` Andrew Baumann
2015-12-07 9:52 ` Paolo Bonzini [this message]
2015-12-07 21:53 ` Andrew Baumann
2015-12-09 14:58 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566556E7.6000000@redhat.com \
--to=pbonzini@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).