From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5sTM-0000C4-2Y for qemu-devel@nongnu.org; Mon, 07 Dec 2015 04:52:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5sTI-0001Hv-Tt for qemu-devel@nongnu.org; Mon, 07 Dec 2015 04:52:44 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5sTI-0001Hf-N0 for qemu-devel@nongnu.org; Mon, 07 Dec 2015 04:52:40 -0500 Received: by wmww144 with SMTP id w144so142600191wmw.0 for ; Mon, 07 Dec 2015 01:52:39 -0800 (PST) Sender: Paolo Bonzini References: <1449255530-11088-1-git-send-email-Andrew.Baumann@microsoft.com> <1449255530-11088-3-git-send-email-Andrew.Baumann@microsoft.com> <5664F25B.4020002@redhat.com> From: Paolo Bonzini Message-ID: <566556E7.6000000@redhat.com> Date: Mon, 7 Dec 2015 10:52:39 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Baumann , Jason Wang , "qemu-devel@nongnu.org" On 07/12/2015 06:20, Andrew Baumann wrote: > Yeah, I considered doing that, but figured that those cases > (incorrectly-sized register writes in 16-bit mode) are indicative of > a pretty badly screwed-up guest, and was going for a minimal patch. > It probably makes sense to change them for consistency, though. I think those should be fixed by modifying lan9118_*_mem_ops and adding .valid.{min,max}_access_size. Not for 2.5, however. (Probably these patches should also be 2.6 + qemu-stable rather than 2.5). Paolo