From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,
Laurent Vivier <laurent@vivier.eu>,
Paolo Bonzini <pbonzini@redhat.com>,
Zhao Liu <zhao1.liu@intel.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH-for-11.0 v2 03/12] target/i386: Use little-endian variant of cpu_ld/st_data*()
Date: Wed, 26 Nov 2025 10:03:48 -0800 [thread overview]
Message-ID: <566747ef-a2e5-4109-8649-44836a319b2b@linaro.org> (raw)
In-Reply-To: <20251126075003.4826-4-philmd@linaro.org>
On 11/25/25 23:49, Philippe Mathieu-Daudé wrote:
> We only build the X86 targets using little endianness order,
> therefore the cpu_ld/st_data*() definitions expand to the little
> endian declarations. Use the explicit little-endian variants.
>
> Mechanical change running:
>
> $ tgt=i386; \
> end=le; \
> for op in data mmuidx_ra; do \
> for ac in uw sw l q; do \
> sed -i -e "s/cpu_ld${ac}_${op}/cpu_ld${ac}_${end}_${op}/" \
> $(git grep -l cpu_ target/${tgt}/); \
> done;
> for ac in w l q; do \
> sed -i -e "s/cpu_st${ac}_${op}/cpu_st${ac}_${end}_${op}/" \
> $(git grep -l cpu_ target/${tgt}/); \
> done;
> done
>
> Then adapting indentation in helper_vmload() to pass checkpatch.pl.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/i386/ops_sse.h | 12 ++---
> target/i386/tcg/seg_helper.h | 12 ++---
> linux-user/vm86.c | 4 +-
> target/i386/tcg/mem_helper.c | 8 ++--
> target/i386/tcg/mpx_helper.c | 28 +++++------
> target/i386/tcg/seg_helper.c | 16 +++----
> target/i386/tcg/system/excp_helper.c | 8 ++--
> target/i386/tcg/system/svm_helper.c | 69 +++++++++++++++-------------
> 8 files changed, 80 insertions(+), 77 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-11-26 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 7:49 [PATCH-for-11.0 v2 00/12] accel/tcg: Remove most MO_TE uses in cpu_ld/st_data() Philippe Mathieu-Daudé
2025-11-26 7:49 ` [PATCH-for-11.0 v2 01/12] target/hexagon: Use little-endian variant of cpu_ld/st_data*() Philippe Mathieu-Daudé
2025-11-26 18:01 ` Richard Henderson
2025-11-26 7:49 ` [PATCH-for-11.0 v2 02/12] target/hppa: " Philippe Mathieu-Daudé
2025-11-26 18:03 ` Richard Henderson
2025-11-26 7:49 ` [PATCH-for-11.0 v2 03/12] target/i386: " Philippe Mathieu-Daudé
2025-11-26 18:03 ` Richard Henderson [this message]
2025-11-26 7:49 ` [PATCH-for-11.0 v2 04/12] target/riscv: Use little-endian variant of cpu_ld/st_data*() for vector Philippe Mathieu-Daudé
2025-11-26 9:16 ` Daniel Henrique Barboza
2025-11-26 7:49 ` [PATCH-for-11.0 v2 05/12] target/rx: Use little-endian variant of cpu_ld/st_data*() Philippe Mathieu-Daudé
2025-11-26 18:05 ` Richard Henderson
2025-11-26 7:49 ` [PATCH-for-11.0 v2 06/12] target/tricore: " Philippe Mathieu-Daudé
2025-11-26 18:06 ` Richard Henderson
2025-11-26 7:49 ` [PATCH-for-11.0 v2 07/12] target/m68k: Use big-endian " Philippe Mathieu-Daudé
2025-11-26 7:49 ` [PATCH-for-11.0 v2 08/12] target/s390x: " Philippe Mathieu-Daudé
2025-11-26 8:23 ` Thomas Huth
2025-11-26 7:50 ` [PATCH-for-11.0 v2 09/12] target/sparc: " Philippe Mathieu-Daudé
2025-11-26 18:10 ` Richard Henderson
2025-11-26 7:50 ` [PATCH-for-11.0 v2 10/12] target/sh4: Replace cpu_stl_data() by explicit endianness variants Philippe Mathieu-Daudé
2025-11-26 7:50 ` [PATCH-for-11.0 v2 11/12] target/mips: Use big-endian variant of cpu_ld/st_data*() for MSA opcode Philippe Mathieu-Daudé
2025-11-26 7:50 ` [PATCH-for-11.0 v2 12/12] accel/tcg: Remove non-explicit endian cpu_ld/st*_data*() helpers Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566747ef-a2e5-4109-8649-44836a319b2b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eduardo@habkost.net \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).