From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6VUx-0005uU-8u for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:33:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6VUw-0003v1-BH for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:32:59 -0500 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:34288) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6VUw-0003uC-5e for qemu-devel@nongnu.org; Tue, 08 Dec 2015 22:32:58 -0500 Received: by pacwq6 with SMTP id wq6so22294097pac.1 for ; Tue, 08 Dec 2015 19:32:57 -0800 (PST) References: <1449459280-14983-1-git-send-email-david@gibson.dropbear.id.au> <1449459280-14983-7-git-send-email-david@gibson.dropbear.id.au> From: Alexey Kardashevskiy Message-ID: <5667A0E2.7080307@ozlabs.ru> Date: Wed, 9 Dec 2015 14:32:50 +1100 MIME-Version: 1.0 In-Reply-To: <1449459280-14983-7-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2 06/10] pseries: Use SET_MACHINE_COMPAT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , ehabkost@redhat.com, agraf@suse.de, mdroth@linux.vnet.ibm.com Cc: lvivier@redhat.com, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 12/07/2015 02:34 PM, David Gibson wrote: > To make the spapr_machine_*_class_init() functions a little less bulky. > > Signed-off-by: David Gibson > --- > hw/ppc/spapr.c | 24 ++++-------------------- > 1 file changed, 4 insertions(+), 20 deletions(-) > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index b08d338..3078e60 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -2329,13 +2329,9 @@ static const TypeInfo spapr_machine_2_5_info = { > > static void spapr_machine_2_4_class_init(ObjectClass *oc, void *data) > { > - static GlobalProperty compat_props[] = { > - SPAPR_COMPAT_2_4 > - { /* end of list */ } > - }; > MachineClass *mc = MACHINE_CLASS(oc); > > - mc->compat_props = compat_props; > + SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_4); > } > > static const TypeInfo spapr_machine_2_4_info = { > @@ -2369,13 +2365,9 @@ static void spapr_machine_2_3_instance_init(Object *obj) > > static void spapr_machine_2_3_class_init(ObjectClass *oc, void *data) > { > - static GlobalProperty compat_props[] = { > - SPAPR_COMPAT_2_3 > - { /* end of list */ } > - }; > MachineClass *mc = MACHINE_CLASS(oc); > > - mc->compat_props = compat_props; > + SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_3); > } > > static const TypeInfo spapr_machine_2_3_info = { > @@ -2410,13 +2402,9 @@ static void spapr_machine_2_2_instance_init(Object *obj) > > static void spapr_machine_2_2_class_init(ObjectClass *oc, void *data) > { > - static GlobalProperty compat_props[] = { > - SPAPR_COMPAT_2_2 > - { /* end of list */ } > - }; > MachineClass *mc = MACHINE_CLASS(oc); > > - mc->compat_props = compat_props; > + SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_2); > } > > static const TypeInfo spapr_machine_2_2_info = { > @@ -2446,12 +2434,8 @@ static void spapr_machine_2_1_instance_init(Object *obj) > static void spapr_machine_2_1_class_init(ObjectClass *oc, void *data) > { > MachineClass *mc = MACHINE_CLASS(oc); > - static GlobalProperty compat_props[] = { > - SPAPR_COMPAT_2_1 > - { /* end of list */ } > - }; > > - mc->compat_props = compat_props; > + SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_1); > } > > static const TypeInfo spapr_machine_2_1_info = { > Reviewed-by: Alexey Kardashevskiy -- Alexey