From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/6] block: byte-based AIO read/write
Date: Tue, 24 Apr 2018 15:13:46 -0400 [thread overview]
Message-ID: <5667b131-9105-1685-3cfc-f97c700ce9ae@redhat.com> (raw)
In-Reply-To: <9c4fcd99-8a8c-62d3-3c0d-d26601910835@redhat.com>
On 04/24/2018 11:02 AM, Eric Blake wrote:
> On 02/15/2018 01:28 PM, Eric Blake wrote:
>> While we would prefer that block drivers use coroutines instead
>> of aio callbacks, it is a fairly easy exercise to prove that
>> all existing drivers with aio callbacks are merely scaling
>> from bytes into sectors and back to bytes. So, even though I
>> am not set up to completely run (or even compile-test) this
>> full series, it seems pretty straightforward to change the
>> signature to quit playing games with pointless scaling.
>>
>> Note that except for the null-aio driver, I intentionally did
>> NOT try and change the request_alignment from the block layer's
>> default of 512 (it defaults to 1 only for drivers that use
>> coroutines).
>>
>> (And along the way, I got my docker-test-mingw@fedora working;
>> thanks to the help I got on IRC)
>
> ping
>
One of your replies to patch 3 suggests you were going to send a v2 --
is that not the case? Do you want deeper review of v1 first?
--js
prev parent reply other threads:[~2018-04-24 19:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 19:28 [Qemu-devel] [PATCH 0/6] block: byte-based AIO read/write Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 1/6] block: Support byte-based aio callbacks Eric Blake
2018-04-24 15:40 ` Kevin Wolf
2018-04-24 17:06 ` Eric Blake
2018-04-24 17:15 ` Kevin Wolf
2018-04-24 19:16 ` Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 2/6] file-win32: Switch to byte-based callbacks Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 3/6] null: Switch to byte-based read/write Eric Blake
2018-04-24 15:52 ` Kevin Wolf
2018-04-24 17:00 ` Eric Blake
2018-04-24 17:19 ` Kevin Wolf
2018-04-24 17:40 ` Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 4/6] rbd: Switch to byte-based callbacks Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 5/6] vxhs: " Eric Blake
2018-02-15 19:28 ` [Qemu-devel] [PATCH 6/6] block: Drop last of the sector-based aio callbacks Eric Blake
2018-04-24 15:02 ` [Qemu-devel] [PATCH 0/6] block: byte-based AIO read/write Eric Blake
2018-04-24 19:13 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5667b131-9105-1685-3cfc-f97c700ce9ae@redhat.com \
--to=jsnow@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).