From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6gCY-0006F3-3A for qemu-devel@nongnu.org; Wed, 09 Dec 2015 09:58:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6gCU-0000fb-UA for qemu-devel@nongnu.org; Wed, 09 Dec 2015 09:58:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6gCU-0000fX-Oe for qemu-devel@nongnu.org; Wed, 09 Dec 2015 09:58:38 -0500 References: <1449255530-11088-1-git-send-email-Andrew.Baumann@microsoft.com> <1449255530-11088-3-git-send-email-Andrew.Baumann@microsoft.com> <5664F25B.4020002@redhat.com> <566556E7.6000000@redhat.com> From: Paolo Bonzini Message-ID: <56684198.202@redhat.com> Date: Wed, 9 Dec 2015 15:58:32 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] lan9118: log and ignore access to invalid registers, rather than aborting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Baumann , Jason Wang , "qemu-devel@nongnu.org" On 07/12/2015 22:53, Andrew Baumann wrote: >>> I think those should be fixed by modifying lan9118_*_mem_ops and >>> adding .valid.{min,max}_access_size. Not for 2.5, however. >>> (Probably these patches should also be 2.6 + qemu-stable rather >>> than 2.5). > Just to clarify: would you guys like me to prepare such a patch? No, it's not necessary. Paolo > I'm > not familiar with the memory op APIs, and don't have a good setup for > testing this device emulation any more (and certainly not in 16-bit > mode!), so would prefer to defer to someone else. > > BTW, I also see no great urgency for these patches. They're minor > fixes, and it would be good to have them in, but it's certainly not a > regression as the code has been that way for ages.