From: Paolo Bonzini <pbonzini@redhat.com>
To: Ashok Raj <ashok.raj@intel.com>, qemu-devel@nongnu.org
Cc: Gleb Natapov <gleb@kernel.org>, Andi Kleen <andi.kleen@intel.com>,
Boris Petkov <bp@suse.de>, Eduardo Habkost <ehabkost@redhat.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU
Date: Wed, 9 Dec 2015 22:07:48 +0100 [thread overview]
Message-ID: <56689824.7030203@redhat.com> (raw)
In-Reply-To: <1449691029-15525-2-git-send-email-ashok.raj@intel.com>
On 09/12/2015 20:57, Ashok Raj wrote:
> + /*
> + * We need to read back the value of MSREXT_MCG_CTL that was set by the
> + * guest kernel back into Qemu
> + */
> + cs->kvm_vcpu_dirty = false;
> + cpu_synchronize_state(cs);
This should not be necessary. I've only skimmed the patches but, apart
from this, the patches look good. Eduardo knows more than me about
machine types and backwards compatibility to older kernels, however, and
I'm deferring to him on this aspect.
How was this tested? (In general, how do you test MCE? :))
Paolo
next prev parent reply other threads:[~2015-12-09 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 19:57 [Qemu-devel] [Patch V0] This patch adds some support required for KVM in order to support LMCE Ashok Raj
2015-12-09 19:57 ` [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU Ashok Raj
2015-12-09 21:07 ` Paolo Bonzini [this message]
2015-12-09 23:05 ` Raj, Ashok
2015-12-09 22:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56689824.7030203@redhat.com \
--to=pbonzini@redhat.com \
--cc=andi.kleen@intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=ehabkost@redhat.com \
--cc=gleb@kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).