From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6lxw-0000j5-PA for qemu-devel@nongnu.org; Wed, 09 Dec 2015 16:08:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6lxt-00052f-Jw for qemu-devel@nongnu.org; Wed, 09 Dec 2015 16:08:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6lxt-00052F-Eg for qemu-devel@nongnu.org; Wed, 09 Dec 2015 16:07:57 -0500 References: <1449691029-15525-1-git-send-email-ashok.raj@intel.com> <1449691029-15525-2-git-send-email-ashok.raj@intel.com> From: Paolo Bonzini Message-ID: <56689824.7030203@redhat.com> Date: Wed, 9 Dec 2015 22:07:48 +0100 MIME-Version: 1.0 In-Reply-To: <1449691029-15525-2-git-send-email-ashok.raj@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Patch V0] x86, mce: Basic support to add LMCE support to QEMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashok Raj , qemu-devel@nongnu.org Cc: Gleb Natapov , Andi Kleen , Boris Petkov , Eduardo Habkost , Tony Luck On 09/12/2015 20:57, Ashok Raj wrote: > + /* > + * We need to read back the value of MSREXT_MCG_CTL that was set b= y the > + * guest kernel back into Qemu > + */ > + cs->kvm_vcpu_dirty =3D false; > + cpu_synchronize_state(cs); This should not be necessary. I've only skimmed the patches but, apart from this, the patches look good. Eduardo knows more than me about machine types and backwards compatibility to older kernels, however, and I'm deferring to him on this aspect. How was this tested? (In general, how do you test MCE? :)) Paolo