From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6qNm-0002EY-Bs for qemu-devel@nongnu.org; Wed, 09 Dec 2015 20:50:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6qNh-0003v3-95 for qemu-devel@nongnu.org; Wed, 09 Dec 2015 20:50:58 -0500 Message-ID: <5668DA65.5080700@huawei.com> Date: Thu, 10 Dec 2015 09:50:29 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-25-git-send-email-imammedo@redhat.com> In-Reply-To: <1449704528-289297-25-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 24/74] acpi: extend aml_interrupt() to support multiple irqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org On 2015/12/10 7:41, Igor Mammedov wrote: > static void acpi_dsdt_add_virtio(Aml *scope, > const MemMapEntry *virtio_mmio_memmap, > - int mmio_irq, int num) > + uint32_t mmio_irq, int num) > { > hwaddr base = virtio_mmio_memmap->base; > hwaddr size = virtio_mmio_memmap->size; > - int irq = mmio_irq; > + uint32_t irq = mmio_irq; > int i; > > for (i = 0; i < num; i++) { > @@ -152,15 +152,15 @@ static void acpi_dsdt_add_virtio(Aml *scope, > aml_append(crs, aml_memory32_fixed(base, size, AML_READ_WRITE)); > aml_append(crs, > aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH, > - AML_EXCLUSIVE, irq + i)); > + AML_EXCLUSIVE, &irq, 1)); This looks not right. You could move uint32_t irq = mmio_irq; into the for loop and make it as uint32_t irq = mmio_irq + i; Thanks, -- Shannon