From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a6x0w-0005iN-1x
	for qemu-devel@nongnu.org; Thu, 10 Dec 2015 03:55:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1a6x0r-0000zz-VU
	for qemu-devel@nongnu.org; Thu, 10 Dec 2015 03:55:49 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1449716386-5652-1-git-send-email-lszhu@suse.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56693E0C.8000003@redhat.com>
Date: Thu, 10 Dec 2015 09:55:40 +0100
MIME-Version: 1.0
In-Reply-To: <1449716386-5652-1-git-send-email-lszhu@suse.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16
	sent
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Zhu Lingshan <lszhu@suse.com>, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: pl@kamp.de, ronniesahlberg@gmail.com



On 10/12/2015 03:59, Zhu Lingshan wrote:
> -    if (task == NULL || task->status != SCSI_STATUS_GOOD) {
> +    if ((rc16 != NULL) && ((task == NULL) || (task->status != SCSI_STATUS_GOOD))) {
> +        error_setg(errp, "iSCSI: failed to send readcapacity16 command.");
> +    }

You need an "else" here.

Paolo

> +    if ((rc10 != NULL) && ((task == NULL) || (task->status != SCSI_STATUS_GOOD))) {
>          error_setg(errp, "iSCSI: failed to send readcapacity10 command.");
>      } else if (!iscsilun->block_size ||