From: Zhu Lingshan <lszhu@suse.com>
To: Peter Lieven <pl@kamp.de>, Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent
Date: Thu, 10 Dec 2015 17:08:07 +0800 [thread overview]
Message-ID: <566940F7.20906@suse.com> (raw)
In-Reply-To: <56693E7C.2080206@kamp.de>
Yeah, I assume that is an easy and efficient solution
Thanks
On 12/10/2015 04:57 PM, Peter Lieven wrote:
> Am 10.12.2015 um 09:55 schrieb Paolo Bonzini:
>>
>> On 10/12/2015 03:59, Zhu Lingshan wrote:
>>> - if (task == NULL || task->status != SCSI_STATUS_GOOD) {
>>> + if ((rc16 != NULL) && ((task == NULL) || (task->status !=
>>> SCSI_STATUS_GOOD))) {
>>> + error_setg(errp, "iSCSI: failed to send readcapacity16
>>> command.");
>>> + }
>> You need an "else" here.
>
> rc16 can't be not NULL if task is NULL.
>
> I would not spent to much energie here and just adjust the error
> message to
>
> "iSCSI: failed to send readcapacity10/16 command."
>
> Peter
>
>
>
prev parent reply other threads:[~2015-12-10 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:59 [Qemu-devel] [PATCH] fix:readcapacity 10 failure shown even 16 sent Zhu Lingshan
2015-12-10 8:55 ` Paolo Bonzini
2015-12-10 8:57 ` Peter Lieven
2015-12-10 9:08 ` Zhu Lingshan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566940F7.20906@suse.com \
--to=lszhu@suse.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).