From: Paolo Bonzini <pbonzini@redhat.com>
To: Hollis Blanchard <hollis_blanchard@mentor.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints
Date: Thu, 10 Dec 2015 10:27:05 +0100 [thread overview]
Message-ID: <56694569.3050204@redhat.com> (raw)
In-Reply-To: <5668C9D9.8010209@mentor.com>
On 10/12/2015 01:39, Hollis Blanchard wrote:
>
> Not sure I understand. Do you mean something like this?
> -trace_memory_region_ops_write(mr, addr, tmp, size);
> +trace_memory_region_ops_write(mr, addr, mr->ops->write ==
> subpage_write, tmp, size);
There is also a mr->subpage that you can use.
> Maybe this isn't the right tracepoint to begin with. I'm trying to trace
> guest MMIO activity; is there a better place to intercept that?
It's the right one, but the problem with tracepoints is that other
people may use them for something other than what you envisioned. For
them, including subpages may be the right thing. Adding a flag to the
tracepoint is the middle ground.
I'm okay also with the solution you proposed in the other message.
Paolo
next prev parent reply other threads:[~2015-12-10 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 1:09 [Qemu-devel] [PATCH 1/2] docs: "simple" trace backend does support strings Hollis Blanchard
2015-11-12 1:09 ` [Qemu-devel] [PATCH 2/2] trace: show MemoryRegion name, not address Hollis Blanchard
2015-11-13 10:23 ` Stefan Hajnoczi
2015-11-13 14:08 ` Paolo Bonzini
2015-11-18 0:37 ` Hollis Blanchard
2015-11-25 7:20 ` Stefan Hajnoczi
2015-12-09 20:54 ` [Qemu-devel] subpage_write() and duplicated memory_region_ops_write tracepoints Hollis Blanchard
2015-12-09 21:12 ` Paolo Bonzini
2015-12-10 0:39 ` Hollis Blanchard
2015-12-10 9:27 ` Paolo Bonzini [this message]
2015-12-10 1:01 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56694569.3050204@redhat.com \
--to=pbonzini@redhat.com \
--cc=hollis_blanchard@mentor.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).