From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6ymh-00089J-1V for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:49:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6ymg-0004WY-6U for qemu-devel@nongnu.org; Thu, 10 Dec 2015 05:49:14 -0500 References: <1449742760-6310-1-git-send-email-armbru@redhat.com> From: Paolo Bonzini Message-ID: <5669589E.4050904@redhat.com> Date: Thu, 10 Dec 2015 11:49:02 +0100 MIME-Version: 1.0 In-Reply-To: <1449742760-6310-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Eduardo Habkost , "Michael S. Tsirkin" On 10/12/2015 11:19, Markus Armbruster wrote: > + object_property_set_int(OBJECT(cpu), ZYNQ_BOARD_MIDR, "midr", > + &error_fatal);object_property_set_int(OBJECT(cpu), > + MPCORE_PERIPHBASE, > + "reset-cbar", > + &error_fatal);object_property_set_bool(OBJECT(cpu), > + true, > + "realized", > + &error_fatal); Something went wrong here. :) > void qdev_prop_set_drive_nofail(DeviceState *dev, const char *name, > BlockBackend *value) > { > - Error *err = NULL; > - > - qdev_prop_set_drive(dev, name, value, &err); > - if (err) { > - error_report_err(err); > - exit(1); > - } > + qdev_prop_set_drive(dev, name, value, &error_fatal); > } This should be inlined entirely into the callers (possibly as a follow up). Otherwise looks great, thanks! Paolo