From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70j3-0001Zx-6J for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:53:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a70ix-0006ur-Vr for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:53:37 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:35500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70ix-0006uk-PI for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:53:31 -0500 Received: by mail-wm0-x22a.google.com with SMTP id u63so22578710wmu.0 for ; Thu, 10 Dec 2015 04:53:31 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-7-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <566975C9.6020303@gmail.com> Date: Thu, 10 Dec 2015 14:53:29 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-7-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/74] acpi: add aml_create_qword_field() Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:41 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 21 +++++++++++++++++---- > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index bb2c9f7..a6e4c54 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -805,17 +805,30 @@ Aml *aml_field(const char *name, AmlAccessType type, AmlUpdateRule rule) > return var; > } > > -/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateDWordField */ > -Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name) > +static > +Aml *create_field_common(int opcode, Aml *srcbuf, Aml *index, const char *name) > { > - Aml *var = aml_alloc(); > - build_append_byte(var->buf, 0x8A); /* CreateDWordFieldOp */ > + Aml *var = aml_opcode(opcode); > aml_append(var, srcbuf); > aml_append(var, index); > build_append_namestring(var->buf, "%s", name); > return var; > } > > +/* ACPI 1.0b: 16.2.5.2 Named Objects Encoding: DefCreateDWordField */ > +Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name) > +{ > + return create_field_common(0x8A /* CreateDWordFieldOp */, > + srcbuf, index, name); > +} > + > +/* ACPI 2.0a: 17.2.4.2 Named Objects Encoding: DefCreateQWordField */ > +Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const char *name) > +{ > + return create_field_common(0x8F /* CreateQWordFieldOp */, > + srcbuf, index, name); > +} > + > /* ACPI 1.0b: 16.2.3 Data Objects Encoding: String */ > Aml *aml_string(const char *name_format, ...) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index b220b12..c113b17 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -275,6 +275,7 @@ Aml *aml_mutex(const char *name, uint8_t sync_level); > Aml *aml_acquire(Aml *mutex, uint16_t timeout); > Aml *aml_release(Aml *mutex); > Aml *aml_create_dword_field(Aml *srcbuf, Aml *index, const char *name); > +Aml *aml_create_qword_field(Aml *srcbuf, Aml *index, const char *name); > Aml *aml_varpackage(uint32_t num_elements); > Aml *aml_touuid(const char *uuid); > Aml *aml_unicode(const char *str); > Reviewed-by: Marcel Apfelbaum