From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70oY-0004m1-PL for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:59:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a70oU-0008VQ-LZ for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:59:18 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:33294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70oU-0008VI-Bz for qemu-devel@nongnu.org; Thu, 10 Dec 2015 07:59:14 -0500 Received: by mail-wm0-x230.google.com with SMTP id c201so31794875wme.0 for ; Thu, 10 Dec 2015 04:59:14 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-9-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <5669771F.9000404@gmail.com> Date: Thu, 10 Dec 2015 14:59:11 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-9-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/74] acpi: extend aml_add() to accept target argument Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:41 AM, Igor Mammedov wrote: > it allows to express following ASL expression: > Add(arg1, arg2, result) > > usecases that do not need to store result > should pass NULL as 3rd arg that would express > Add(arg1, arg2,) > construct. > > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 4 ++-- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 22015d2..3bb19bf 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -497,9 +497,9 @@ Aml *aml_lless(Aml *arg1, Aml *arg2) > } > > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefAdd */ > -Aml *aml_add(Aml *arg1, Aml *arg2) > +Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst) > { > - return build_opcode_2arg_dst(0x72 /* AddOp */, arg1, arg2, NULL); > + return build_opcode_2arg_dst(0x72 /* AddOp */, arg1, arg2, dst); > } > > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIncrement */ > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 95e0c65..bce0252 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -669,7 +669,7 @@ static Aml *build_prt(void) > aml_store(aml_shiftright(pin, aml_int(2)), slot)); > /* lnk_idx = (slot + pin) & 3 */ > aml_append(while_ctx, > - aml_store(aml_and(aml_add(pin, slot), aml_int(3)), lnk_idx)); > + aml_store(aml_and(aml_add(pin, slot, NULL), aml_int(3)), lnk_idx)); > > /* route[2] = "LNK[D|A|B|C]", selection based on pin % 3 */ > aml_append(while_ctx, initialize_route(route, "LNKD", lnk_idx, 0)); > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index c113b17..da38c92 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -204,7 +204,7 @@ Aml *aml_or(Aml *arg1, Aml *arg2); > Aml *aml_shiftleft(Aml *arg1, Aml *count); > Aml *aml_shiftright(Aml *arg1, Aml *count); > Aml *aml_lless(Aml *arg1, Aml *arg2); > -Aml *aml_add(Aml *arg1, Aml *arg2); > +Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst); > Aml *aml_increment(Aml *arg); > Aml *aml_index(Aml *arg1, Aml *idx); > Aml *aml_notify(Aml *arg1, Aml *arg2); > Reviewed-by: Marcel Apfelbaum