From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70rC-0006Mt-1y for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:02:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a70r7-0001Q9-V3 for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:02:02 -0500 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:35051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70r7-0001Pj-OD for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:01:57 -0500 Received: by mail-wm0-x232.google.com with SMTP id u63so22888810wmu.0 for ; Thu, 10 Dec 2015 05:01:57 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-10-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <566977C3.6020509@gmail.com> Date: Thu, 10 Dec 2015 15:01:55 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-10-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/74] acpi: add aml_decrement() and aml_subtract() Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:41 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 14 ++++++++++++++ > include/hw/acpi/aml-build.h | 2 ++ > 2 files changed, 16 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 3bb19bf..ee34771 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -502,6 +502,12 @@ Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst) > return build_opcode_2arg_dst(0x72 /* AddOp */, arg1, arg2, dst); > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefSubtract */ > +Aml *aml_subtract(Aml *arg1, Aml *arg2, Aml *dst) > +{ > + return build_opcode_2arg_dst(0x74 /* SubtractOp */, arg1, arg2, dst); > +} > + > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIncrement */ > Aml *aml_increment(Aml *arg) > { > @@ -510,6 +516,14 @@ Aml *aml_increment(Aml *arg) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefDecrement */ > +Aml *aml_decrement(Aml *arg) > +{ > + Aml *var = aml_opcode(0x76 /* DecrementOp */); > + aml_append(var, arg); > + return var; > +} > + > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefIndex */ > Aml *aml_index(Aml *arg1, Aml *idx) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index da38c92..9761438 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -205,7 +205,9 @@ Aml *aml_shiftleft(Aml *arg1, Aml *count); > Aml *aml_shiftright(Aml *arg1, Aml *count); > Aml *aml_lless(Aml *arg1, Aml *arg2); > Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst); > +Aml *aml_subtract(Aml *arg1, Aml *arg2, Aml *dst); > Aml *aml_increment(Aml *arg); > +Aml *aml_decrement(Aml *arg); > Aml *aml_index(Aml *arg1, Aml *idx); > Aml *aml_notify(Aml *arg1, Aml *arg2); > Aml *aml_call1(const char *method, Aml *arg1); > Reviewed-by: Marcel Apfelbaum