From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70xJ-0002Co-KG for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:08:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a70xF-0003zk-H5 for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:08:21 -0500 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:38775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a70xF-0003zW-BL for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:08:17 -0500 Received: by wmec201 with SMTP id c201so24029708wme.1 for ; Thu, 10 Dec 2015 05:08:16 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-13-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <5669793E.3070101@gmail.com> Date: Thu, 10 Dec 2015 15:08:14 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-13-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/74] acpi: extend aml_shiftright() to accept target argument Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:41 AM, Igor Mammedov wrote: > it allows to express ShiftRight(A,B,C) syntax > > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 4 ++-- > hw/i386/acpi-build.c | 2 +- > include/hw/acpi/aml-build.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 1f599e3..dcaa7e9 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -491,9 +491,9 @@ Aml *aml_shiftleft(Aml *arg1, Aml *count) > } > > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefShiftRight */ > -Aml *aml_shiftright(Aml *arg1, Aml *count) > +Aml *aml_shiftright(Aml *arg1, Aml *count, Aml *dst) > { > - return build_opcode_2arg_dst(0x7A /* ShiftRightOp */, arg1, count, NULL); > + return build_opcode_2arg_dst(0x7A /* ShiftRightOp */, arg1, count, dst); > } > > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLLess */ > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index bce0252..8f7b95a 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -666,7 +666,7 @@ static Aml *build_prt(void) > > /* slot = pin >> 2 */ > aml_append(while_ctx, > - aml_store(aml_shiftright(pin, aml_int(2)), slot)); > + aml_store(aml_shiftright(pin, aml_int(2), NULL), slot)); > /* lnk_idx = (slot + pin) & 3 */ > aml_append(while_ctx, > aml_store(aml_and(aml_add(pin, slot, NULL), aml_int(3)), lnk_idx)); > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index d28bfe6..a694a67 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -203,7 +203,7 @@ Aml *aml_store(Aml *val, Aml *target); > Aml *aml_and(Aml *arg1, Aml *arg2); > Aml *aml_or(Aml *arg1, Aml *arg2); > Aml *aml_shiftleft(Aml *arg1, Aml *count); > -Aml *aml_shiftright(Aml *arg1, Aml *count); > +Aml *aml_shiftright(Aml *arg1, Aml *count, Aml *dst); > Aml *aml_lless(Aml *arg1, Aml *arg2); > Aml *aml_add(Aml *arg1, Aml *arg2, Aml *dst); > Aml *aml_subtract(Aml *arg1, Aml *arg2, Aml *dst); > Reviewed-by: Marcel Apfelbaum