From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a71Ef-0003o4-4m for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a71Ec-0008Lq-7F for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:26:17 -0500 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:36312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a71Ec-0008LX-1U for qemu-devel@nongnu.org; Thu, 10 Dec 2015 08:26:14 -0500 Received: by mail-wm0-x234.google.com with SMTP id w144so23773346wmw.1 for ; Thu, 10 Dec 2015 05:26:13 -0800 (PST) References: <1449704528-289297-1-git-send-email-imammedo@redhat.com> <1449704528-289297-18-git-send-email-imammedo@redhat.com> From: Marcel Apfelbaum Message-ID: <56697D73.3080101@gmail.com> Date: Thu, 10 Dec 2015 15:26:11 +0200 MIME-Version: 1.0 In-Reply-To: <1449704528-289297-18-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/74] acpi: add aml_lgreater() Reply-To: marcel@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org On 12/10/2015 01:41 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 9 +++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 8cfa65c..b22e7da 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -715,6 +715,15 @@ Aml *aml_equal(Aml *arg1, Aml *arg2) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLGreater */ > +Aml *aml_lgreater(Aml *arg1, Aml *arg2) > +{ > + Aml *var = aml_opcode(0x94 /* LGreaterOp */); > + aml_append(var, arg1); > + aml_append(var, arg2); > + return var; > +} > + > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLGreaterEqual */ > Aml *aml_lgreater_equal(Aml *arg1, Aml *arg2) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index 897e093..238a9dc 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -240,6 +240,7 @@ Aml *aml_local(int num); > Aml *aml_string(const char *name_format, ...) GCC_FMT_ATTR(1, 2); > Aml *aml_lnot(Aml *arg); > Aml *aml_equal(Aml *arg1, Aml *arg2); > +Aml *aml_lgreater(Aml *arg1, Aml *arg2); > Aml *aml_lgreater_equal(Aml *arg1, Aml *arg2); > Aml *aml_processor(uint8_t proc_id, uint32_t pblk_addr, uint8_t pblk_len, > const char *name_format, ...) GCC_FMT_ATTR(4, 5); > Reviewed-by: Marcel Apfelbaum