From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56856)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a721q-0008KW-Ek
	for qemu-devel@nongnu.org; Thu, 10 Dec 2015 09:17:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1a721i-0001Tk-Qb
	for qemu-devel@nongnu.org; Thu, 10 Dec 2015 09:17:06 -0500
References: <1449742760-6310-1-git-send-email-armbru@redhat.com>
	<566962E3.4000409@gmail.com> <878u52fpn1.fsf@blackfin.pond.sub.org>
	<56698521.3040707@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56698945.2070709@redhat.com>
Date: Thu, 10 Dec 2015 15:16:37 +0100
MIME-Version: 1.0
In-Reply-To: <56698521.3040707@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Use error_fatal to simplify obvious fatal
 errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcel Apfelbaum <marcel@redhat.com>, Markus Armbruster <armbru@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: qemu-arm@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>



On 10/12/2015 14:58, Marcel Apfelbaum wrote:
> My point is, now we *could* have a guarantee that if anyone uses the old
> way, we can catch it in time. It can be easily lost in the review process.

The right way to do that would be in scripts/checkpatch.pl, by catching
error_report_err followed by exit.

Paolo