From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a799f-0002iY-9U for qemu-devel@nongnu.org; Thu, 10 Dec 2015 16:53:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a799c-00041V-49 for qemu-devel@nongnu.org; Thu, 10 Dec 2015 16:53:39 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:7867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a799b-00041P-Ul for qemu-devel@nongnu.org; Thu, 10 Dec 2015 16:53:36 -0500 Message-ID: <5669F45A.4000002@reactos.org> Date: Thu, 10 Dec 2015 22:53:30 +0100 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1449743372-17169-1-git-send-email-armbru@redhat.com> <1449743372-17169-11-git-send-email-armbru@redhat.com> In-Reply-To: <1449743372-17169-11-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/12] isa: Clean up inappropriate hw_error() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , Aurelien Jarno , Richard Henderson Le 10/12/2015 11:29, Markus Armbruster a =C3=A9crit : > isa_bus_irqs(), isa_create() and isa_try_create() call hw_error() when > passed a null bus. Use of hw_error() has always been questionable, > because these are used only during machine initialization, and > printing CPU registers isn't useful there. > > Since the previous commit, passing a null bus is a programming error. > Drop the hw_error() and simply let it crash. > > Cc: Richard Henderson > Cc: "Michael S. Tsirkin" > Cc: "Herv=C3=A9 Poussineau" > Cc: Aurelien Jarno > Cc: Mark Cave-Ayland > Signed-off-by: Markus Armbruster > --- Creating a second ISA bus raises an error in isa_bus_new, so Reviewed-by: Herv=C3=A9 Poussineau